exchanges: Add Coinbase International support #1381
Conversation
shazbert
left a comment
shazbert
left a comment
There was a problem hiding this comment.
Great work, just had a quick look over code. 👍
| errAddressIsRequired = errors.New("err: missing address") | ||
| errAssetIdentifierRequired = errors.New("err: asset identified is required") | ||
| errEmptyArgument = errors.New("err: empty argument") | ||
| errTimeInForceRequired = errors.New("err: time_in_force is required") |
There was a problem hiding this comment.
Can probably RM err: string
| if orderID == "" { | ||
| return nil, order.ErrOrderIDNotSet | ||
| } | ||
| if arg == (&ModifyOrderParam{}) { |
There was a problem hiding this comment.
needs a nil check
if arg == nil || *arg == (ModifyOrderParam{}) {| params.Set("status", status) | ||
| } | ||
| if transferType != "" { | ||
| params.Set("type", status) |
| value := reflect.ValueOf(data) | ||
| var payload []byte | ||
| if value != (reflect.Value{}) && !value.IsNil() && value.Kind() != reflect.Ptr { | ||
| return errArgumentMustBeInterface | ||
| } else if value != (reflect.Value{}) && !value.IsNil() { | ||
| payload, err = json.Marshal(data) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
There's a lot of stuff going on here. I think we could just go about doing a if data != nil {} check.
Or if the pointer value is really needed:
var payload []byte
if data != nil {
if reflectlite.ValueOf(data).Kind() != reflectlite.Ptr {
return errArgumentMustBePointer
}
payload, err = json.Marshal(data)
if err != nil {
return err
}
}| QuoteAssetUUID string `json:"quote_asset_uuid"` | ||
| QuoteAssetName string `json:"quote_asset_name"` | ||
| BaseIncrement string `json:"base_increment"` | ||
| QuoteIncrement string `json:"quote_increment"` |
There was a problem hiding this comment.
Can you go over these string values across this file and convert them to float64 values? I will highlight a few if they come up.
|
|
||
| // GetRecentTrades returns the most recent trades for a currency and asset | ||
| func (co *CoinbaseInternational) GetRecentTrades(_ context.Context, _ currency.Pair, _ asset.Item) ([]trade.Data, error) { | ||
| return nil, common.ErrNotYetImplemented |
There was a problem hiding this comment.
Not supported? and below?
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return &order.SubmitResponse{ |
There was a problem hiding this comment.
Suggestion: can use method on S to get default order.SubmitResponse if you want.
| if err != nil { | ||
| return err | ||
| } | ||
| return nil |
|
|
||
| // CancelBatchOrders cancels orders by their corresponding ID numbers | ||
| func (co *CoinbaseInternational) CancelBatchOrders(context.Context, []order.Cancel) (*order.CancelBatchResponse, error) { | ||
| return nil, common.ErrNotYetImplemented |
| // WithdrawFiatFunds returns a withdrawal ID when a withdrawal is | ||
| // submitted | ||
| func (co *CoinbaseInternational) WithdrawFiatFunds(context.Context, *withdraw.Request) (*withdraw.ExchangeResponse, error) { | ||
| return nil, common.ErrNotYetImplemented |
There was a problem hiding this comment.
I will stop mentioning this but common.ErrNotSupported
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1381 +/- ##
===========================================
+ Coverage 36.26% 46.32% +10.05%
===========================================
Files 419 366 -53
Lines 183133 120470 -62663
===========================================
- Hits 66421 55806 -10615
+ Misses 108605 56996 -51609
+ Partials 8107 7668 -439
|
… into update_tif # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
… into coinbaseintx
… into coinbaseintx
… into update_tif
… into coinbaseintx
… into coinbaseintx branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
… into coinbaseintx
… into coinbaseintx
|
This PR is stale because it has been open 21 days with no activity. Please provide an update on the progress of this PR. |
… into coinbaseintx
4 participants
ሰላም ወንድሞች፣
PR Description
This pull request Included a code implementation for the Coinbase International exchange version 1; with REST and web socket support. All the Websocket and Wrapper functions are tested. My code follows the style guidelines of other exchanges of GCT. Fixed all linter issues errors with the help of golangci-lint. Endpoint methods that have no support from the GCT wrapper are also implemented for future use.
Fixes # (issue)
Type of change
How has this been tested
Checklist