exchanges: Update exchange templates

backtester/engine/backtest_test.go

@@ -418,7 +418,7 @@ func TestReset(t *testing.T) {
 
 func TestFullCycle(t *testing.T) {
 	t.Parallel()
-	ex := testExchange
+	e := testExchange
 	cp := currency.NewBTCUSDT()
 	a := asset.Spot
 	tt := time.Now()
@@ -431,18 +431,18 @@ func TestFullCycle(t *testing.T) {
 	}, &risk.Risk{}, decimal.Zero)
 	assert.NoError(t, err)
 
-	fx := &binance.Binance{}
+	fx := &binance.Exchange{}
 	fx.Name = testExchange
 	err = port.SetCurrencySettingsMap(&exchange.Settings{Exchange: fx, Asset: a, Pair: cp})
 	assert.NoError(t, err)
 
 	f, err := funding.SetupFundingManager(&engine.ExchangeManager{}, false, true, false)
 	assert.NoError(t, err)
 
-	b, err := funding.CreateItem(ex, a, cp.Base, decimal.Zero, decimal.Zero)
+	b, err := funding.CreateItem(e, a, cp.Base, decimal.Zero, decimal.Zero)
 	assert.NoError(t, err)
 
-	quote, err := funding.CreateItem(ex, a, cp.Quote, decimal.NewFromInt(1337), decimal.Zero)
+	quote, err := funding.CreateItem(e, a, cp.Quote, decimal.NewFromInt(1337), decimal.Zero)
 	assert.NoError(t, err)
 
 	pair, err := funding.CreatePair(b, quote)
@@ -467,7 +467,7 @@ func TestFullCycle(t *testing.T) {
 	bt.DataHolder = data.NewHandlerHolder()
 	k := &kline.DataFromKline{
 		Item: &gctkline.Item{
-			Exchange: ex,
+			Exchange: e,
 			Pair:     cp,
 			Asset:    a,
 			Interval: gctkline.FifteenMin,
@@ -502,7 +502,7 @@ func TestFullCycle(t *testing.T) {
 	err = k.Load()
 	assert.NoError(t, err)
 
-	err = bt.DataHolder.SetDataForCurrency(ex, a, cp, k)
+	err = bt.DataHolder.SetDataForCurrency(e, a, cp, k)
 	assert.NoError(t, err)
 
 	bt.MetaData.DateLoaded = time.Now()
@@ -536,7 +536,7 @@ func TestStop(t *testing.T) {
 
 func TestFullCycleMulti(t *testing.T) {
 	t.Parallel()
-	ex := testExchange
+	e := testExchange
 	cp := currency.NewBTCUSDT()
 	a := asset.Spot
 	tt := time.Now()
@@ -550,16 +550,16 @@ func TestFullCycleMulti(t *testing.T) {
 	}, &risk.Risk{}, decimal.Zero)
 	assert.NoError(t, err)
 
-	err = port.SetCurrencySettingsMap(&exchange.Settings{Exchange: &binance.Binance{}, Asset: a, Pair: cp})
+	err = port.SetCurrencySettingsMap(&exchange.Settings{Exchange: &binance.Exchange{}, Asset: a, Pair: cp})
 	assert.NoError(t, err)
 
 	f, err := funding.SetupFundingManager(&engine.ExchangeManager{}, false, true, false)
 	assert.NoError(t, err)
 
-	b, err := funding.CreateItem(ex, a, cp.Base, decimal.Zero, decimal.Zero)
+	b, err := funding.CreateItem(e, a, cp.Base, decimal.Zero, decimal.Zero)
 	assert.NoError(t, err)
 
-	quote, err := funding.CreateItem(ex, a, cp.Quote, decimal.NewFromInt(1337), decimal.Zero)
+	quote, err := funding.CreateItem(e, a, cp.Quote, decimal.NewFromInt(1337), decimal.Zero)
 	assert.NoError(t, err)
 
 	pair, err := funding.CreatePair(b, quote)
@@ -586,7 +586,7 @@ func TestFullCycleMulti(t *testing.T) {
 	bt.DataHolder = data.NewHandlerHolder()
 	k := &kline.DataFromKline{
 		Item: &gctkline.Item{
-			Exchange: ex,
+			Exchange: e,
 			Pair:     cp,
 			Asset:    a,
 			Interval: gctkline.FifteenMin,
@@ -621,7 +621,7 @@ func TestFullCycleMulti(t *testing.T) {
 	err = k.Load()
 	assert.NoError(t, err)
 
-	err = bt.DataHolder.SetDataForCurrency(ex, a, cp, k)
+	err = bt.DataHolder.SetDataForCurrency(e, a, cp, k)
 	assert.NoError(t, err)
 
 	err = bt.Run()
@@ -762,7 +762,7 @@ func TestUpdateStatsForDataEvent(t *testing.T) {
 	require.NoError(t, err, "CreateCollateral must not error")
 
 	bt.Funding = f
-	exch := &binance.Binance{}
+	exch := &binance.Exchange{}
 	exch.Name = testExchange
 	ev.Time = time.Now()
 	fl := &fill.Fill{
@@ -831,7 +831,7 @@ func TestProcessSignalEvent(t *testing.T) {
 	require.NoError(t, err, "CreateCollateral must not error")
 
 	bt.Funding = f
-	exch := &binance.Binance{}
+	exch := &binance.Exchange{}
 	exch.Name = testExchange
 	bt.Exchange.SetExchangeAssetCurrencySettings(a, cp, &exchange.Settings{
 		Exchange: exch,
@@ -889,7 +889,7 @@ func TestProcessOrderEvent(t *testing.T) {
 	require.NoError(t, err, "CreateCollateral must not error")
 
 	bt.Funding = f
-	exch := &binance.Binance{}
+	exch := &binance.Exchange{}
 	exch.Name = testExchange
 	err = pt.SetCurrencySettingsMap(&exchange.Settings{
 		Exchange: exch,
@@ -1204,7 +1204,7 @@ func TestCloseAllPositions(t *testing.T) {
 	dc.funding = bt.Funding
 	cp := currency.NewBTCUSD()
 	dc.sourcesToCheck = append(dc.sourcesToCheck, &liveDataSourceDataHandler{
-		exchange:                  &binance.Binance{},
+		exchange:                  &binance.Exchange{},
 		exchangeName:              testExchange,
 		asset:                     asset.Spot,
 		pair:                      cp,
@@ -1285,7 +1285,7 @@ func TestRunLive(t *testing.T) {
 	}
 	// 	AppendDataSource(exchange gctexchange.IBotExchange, interval gctkline.Interval, asset asset.Asset, pair, underlyingPair currency.Pair, dataType int64) error
 	setup := &liveDataSourceSetup{
-		exchange:       &binance.Binance{},
+		exchange:       &binance.Exchange{},
 		interval:       i.Interval,
 		asset:          i.Asset,
 		pair:           i.Pair,
@@ -1373,7 +1373,7 @@ func TestSetExchangeCredentials(t *testing.T) {
 	assert.ErrorIs(t, err, gctcommon.ErrNilPointer)
 
 	cfg := &config.Config{}
-	f := &binanceus.Binanceus{}
+	f := &binanceus.Exchange{}
 	f.SetDefaults()
 	b := f.GetBase()
 	err = setExchangeCredentials(cfg, b)
@@ -1416,7 +1416,7 @@ func TestGetFees(t *testing.T) {
 	_, _, err := getFees(t.Context(), nil, currency.EMPTYPAIR)
 	assert.ErrorIs(t, err, gctcommon.ErrNilPointer)
 
-	f := &binance.Binance{}
+	f := &binance.Exchange{}
 	f.SetDefaults()
 	_, _, err = getFees(t.Context(), f, currency.EMPTYPAIR)
 	assert.ErrorIs(t, err, currency.ErrCurrencyPairEmpty)

backtester/engine/live_test.go

@@ -219,7 +219,7 @@ func TestAppendDataSource(t *testing.T) {
 	err = dataHandler.AppendDataSource(setup)
 	assert.ErrorIs(t, err, gctcommon.ErrNilPointer)
 
-	setup.exchange = &binance.Binance{}
+	setup.exchange = &binance.Exchange{}
 	err = dataHandler.AppendDataSource(setup)
 	assert.ErrorIs(t, err, common.ErrInvalidDataType)
 
@@ -264,7 +264,7 @@ func TestFetchLatestData(t *testing.T) {
 	_, err = dataHandler.FetchLatestData()
 	require.NoError(t, err)
 	cp := currency.NewBTCUSDT()
-	f := &binanceus.Binanceus{}
+	f := &binanceus.Exchange{}
 	f.SetDefaults()
 	fb := f.GetBase()
 	require.NoError(t, fb.CurrencyPairs.SetAssetEnabled(asset.Spot, true), "SetAssetEnabled must not error")
@@ -322,7 +322,7 @@ func TestLoadCandleData(t *testing.T) {
 	_, err := l.loadCandleData(time.Now())
 	assert.ErrorIs(t, err, gctcommon.ErrNilPointer)
 
-	exch := &binanceus.Binanceus{}
+	exch := &binanceus.Exchange{}
 	exch.SetDefaults()
 	cp := currency.NewBTCUSDT().Format(
 		currency.PairFormat{
@@ -367,7 +367,7 @@ func TestSetDataForClosingAllPositions(t *testing.T) {
 
 	dataHandler.started = 1
 	cp := currency.NewBTCUSDT()
-	f := &binanceus.Binanceus{}
+	f := &binanceus.Exchange{}
 	f.SetDefaults()
 	fb := f.GetBase()
 	err := fb.CurrencyPairs.StorePairs(asset.Spot, currency.Pairs{cp}, true)

backtester/eventhandlers/exchange/exchange_test.go

@@ -125,7 +125,7 @@ func TestSetCurrency(t *testing.T) {
 	if len(e.CurrencySettings) != 0 {
 		t.Error("expected 0")
 	}
-	f := &binance.Binance{}
+	f := &binance.Exchange{}
 	f.Name = testExchange
 	cs := &Settings{
 		Exchange:      f,
@@ -240,7 +240,7 @@ func TestExecuteOrder(t *testing.T) {
 	require.NoError(t, exchB.CurrencyPairs.SetAssetEnabled(a, true), "SetAssetEnabled must not error")
 	_, err = exch.UpdateOrderbook(t.Context(), p, a)
 	require.NoError(t, err, "UpdateOrderbook must not error")
-	f := &binanceus.Binanceus{}
+	f := &binanceus.Exchange{}
 	f.Name = testExchange
 	cs := Settings{
 		Exchange:            f,
@@ -359,7 +359,7 @@ func TestExecuteOrderBuySellSizeLimit(t *testing.T) {
 	limits, err := exch.GetOrderExecutionLimits(a, p)
 	require.NoError(t, err, "GetOrderExecutionLimits must not error")
 
-	f := &btcmarkets.BTCMarkets{}
+	f := &btcmarkets.Exchange{}
 	f.Name = testExchange
 	cs := Settings{
 		Exchange:      f,

backtester/eventhandlers/exchange/slippage/slippage_test.go

@@ -21,7 +21,7 @@ func TestRandomSlippage(t *testing.T) {
 
 func TestCalculateSlippageByOrderbook(t *testing.T) {
 	t.Parallel()
-	b := bitstamp.Bitstamp{}
+	b := bitstamp.Exchange{}
 	b.SetDefaults()
 
 	cp := currency.NewBTCUSD()