Bitget: Add exchange support #1844

cranktakular · 2025-03-10T06:56:12Z

PR Description

Implementing Bitget's V2 API, specifically the Common, Spot, Future, Margin, Earn, and Inst Loan sections.

In addition, does some smaller fixes across the codebase:

Exports more errors.
Lets types.Number support "null" values, interpreting them as 0.
Removes GetPositionSummary, as there's already GetFuturesPositionSummary, which fulfills the same functionality.

Type of change

Please delete options that are not relevant and add an x in [] as item is complete.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How has this been tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration and also consider improving test coverage whilst working on a certain feature or package.

go test ./... -race
golangci-lint run
Test X

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation and regenerated documentation via the documentation tool
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally and on Github Actions with my changes

…s discovered exchange-side errors

shazbert

Very fine work. Some quick nits to get started.

cmd/exchange_wrapper_issues/main.go

shazbert · 2025-09-23T23:42:23Z

currency/code_types.go

 	AIDOGE           = NewCode("AIDOGE")
 	PEPE             = NewCode("PEPE")
 	USDCM            = NewCode("USDCM")
+	SUSDT            = NewCode("SUSDT")


this is sus

shazbert · 2025-09-23T23:44:30Z

exchanges/bitget/bitget.go

+	// Public endpoints
+	bitgetPublic                   = "public/"
+	bitgetAnnouncements            = "annoucements" // Misspelling of announcements
+	bitgetTime                     = "time"


See if you can consolidate this list to the function calls and remove the bitget prefix on the left over consts

What do you mean by consolidating to function calls?

Removing the prefix will cause some of them to run into conflicts (i.e. time and ticker would conflict with the packages). I could keep prefixes there or add different suffixes, but this would total to a lot of work for a purely cosmetic change.

By consolidation I mean you add the string "/somepath" directly to the path if its not shared in different functions and which might reduce this list. Leave that up to you if you want to change the bitget prefix.

I could definitely consolidate part of these, and the reason to split them out isn't too significant now (it was done so that I could identify new endpoints which share those). But it does seem like a fair bit of work (searching 180 different consts to see how many of them appear multiple times, and appropriately replacing those which only appear once) for minimal reward (editors of this file need to scroll through fewer lines).

I'd rather not change these, but if others disagree, I can.

Yeah that's fine keep as is. 👍

exchanges/bitget/bitget.go

shazbert · 2025-09-23T23:46:38Z

exchanges/bitget/bitget.go

+)
+
+var (
+	errBusinessTypeEmpty              = errors.New("businessType cannot be empty")


suggestion: seems like we might be able to have a common.ErrEmptyValue across this list and then wrap field to it but up to you.

Do you just mean, for most of these values, replacing them with something like = fmt.Errorf("%w: businessType", common.ErrEmptyValue") ?

Yeah something like that but up to you if you want to do that.

I'd rather not unless others request it.

exchanges/bitget/bitget_websocket.go

exchanges/bitget/bitget_wrapper.go

exchanges/bitget/ratelimit.go

samuael

This is a cool PR. I have made a quick review. Will get back to it another round

samuael · 2025-10-12T17:16:47Z

exchanges/orderbook/orderbook.go

 	}

 	if b.Asset.String() == "" {
-		return errAssetTypeNotSet


Could you move this function to the assets folder?

samuael · 2025-10-12T17:17:36Z

exchanges/orderbook/orderbook_types.go

 // Public errors
 var (
 	ErrOrderbookNotFound = errors.New("cannot find orderbook(s)")
+	ErrAssetTypeNotSet   = errors.New("orderbook asset type not set")


I don't think this should be in this package

I think it makes some sense; the orderbook's asset type isn't set, seems fine for the orderbook package.

But I wouldn't be too opposed to moving it.

samuael · 2025-10-12T17:22:08Z

types/number.go

-	case 'n', 't', 'f': // null, true, false
+	case 't', 'f': // true, false
 		return fmt.Errorf("%w: %s", errInvalidNumberValue, data)
+	case 'n': // null


I don't understand why this is an exception since we only checked the first entry and could not be sure to be sure to see whether it is 'n' for 'null' or for 'north'

Since it's JSON, only certain values are allowed outside of quote marks. If a different JSON implementation is sending north, not included inside quote marks, it would not be conforming to standard (RFC8259, section 3).

samuael

Just added few comments on top of what I did before.

exchanges/bitget/bitget.go

samuael · 2025-10-14T20:41:28Z

exchanges/bitget/bitget.go

+	params.Values.Set("status", status)
+	params.Values.Set("side", side)
+	params.Values.Set("language", "en-US")
+	if !cryptoCurrency.IsEmpty() {


You could group these optional variables check together. Just for consistency.

I could, but it's aesthetic and can't easily be automatically detected, so I won't bother; I'll continue leaving them in the order the exchange provided them.

samuael · 2025-10-14T20:46:16Z

exchanges/bitget/bitget_websocket.go

+}
+
+// GenerateDefaultSubscriptions generates default subscriptions
+func (e *Exchange) generateDefaultSubscriptions() (subscription.List, error) {


You can modify this implementation by using the new exchange template implementation.

samuael · 2025-10-14T20:47:03Z

exchanges/bitget/bitget_websocket.go

+			wg.Add(1)
+			go func(req WsRequest) {
+				defer wg.Done()
+				err := e.Websocket.Conn.SendJSONMessage(context.TODO(), rateSubscription, req)


if err := ...; err != nil {}

Ran out of time to completely do this, but I've caught a lot of these. Will catch more next week.

Got the rest of these.

samuael · 2025-10-14T20:47:15Z

exchanges/bitget/bitget_websocket.go

+			wg.Add(1)
+			go func(req WsRequest) {
+				defer wg.Done()
+				err := e.Websocket.AuthConn.SendJSONMessage(context.TODO(), rateSubscription, req)


shorten here too

samuael · 2025-10-14T20:48:40Z

exchanges/bitget/bitget_websocket.go

+
+// AccountUpdateDataHandler
+func (e *Exchange) accountUpdateDataHandler(wsResponse *WsResponse, respRaw []byte) error {
+	creds, err := e.GetCredentials(context.TODO())


pass ctx from the calling instance or use context.Background()

exchanges/bitget/bitget_wrapper.go

samuael

Not all of my last review are applied but I have added more

samuael · 2025-10-27T18:30:57Z

exchanges/bitget/bitget.go

+		vals.Set("period", period)
+	}
+	path := bitgetMargin + bitgetMarket + bitgetIsolatedBorrowRate
+	var resp []BorrowRatioResp


Could you change such occurrences into using a slice of pointers? that way it will become easier to loop over each elements without using indexing

Suggested change

var resp []BorrowRatioResp

var resp []*BorrowRatioResp

What do you mean? It's slightly easier to loop over slices when they aren't of pointers since then you don't need to dereference it afterwards.

sli := []int64{1, 2, 3, 4} for _, b := range sli { fmt.Printf("%v\n", b) }

Compared to

i1, i2, i3, i4 := int64(1), int64(2), int64(3), int64(4) sli := []*int64{&i1, &i2, &i3, &i4} for _, b := range sli { fmt.Printf("%v\n", *b) }

You are not supposed to de-reference this since you only use it to access the data inside it. When you use list of pointers, you can directly use the value from the loop to access it instead of using a slice indexing(result[i]) to load the value at that index.

samuael · 2025-10-27T18:31:08Z

exchanges/bitget/bitget.go

+	vals.Set("symbol", pair.String())
+	vals.Set("period", period)
+	path := bitgetMix + bitgetMarket + bitgetLongShort
+	var resp []RatioResp


samuael · 2025-10-27T18:31:25Z

exchanges/bitget/bitget.go

+	vals := url.Values{}
+	vals.Set("symbol", pair.String())
+	path := bitgetSpot + bitgetMarket + bitgetFundNetFlow
+	var resp []WhaleFundFlowResp


samuael · 2025-10-27T18:32:51Z

exchanges/bitget/bitget.go

+		return nil, errSubaccountEmpty
+	}
+	path := bitgetUser + bitgetCreate + bitgetVirtualSubaccount
+	req := struct {


You can replace this with maps and put it directly into the SendAuthenticatedHTTPRequest method call.

They were maps; you told me to replace them with structs back in May!

samuael · 2025-10-27T18:36:38Z

exchanges/bitget/bitget.go

+func (e *Exchange) GetConvertHistory(ctx context.Context, startTime, endTime time.Time, limit, pagination int64) (*ConvHistResp, error) {
+	var params Params
+	params.Values = make(url.Values)
+	err := params.prepareDateString(startTime, endTime, false, false)


Throughout this code base you can replace such occurances as follow

Suggested change

err := params.prepareDateString(startTime, endTime, false, false)

if err := params.prepareDateString(startTime, endTime, false, false); err != nil {

samuael · 2025-10-27T18:58:10Z

exchanges/bitget/bitget.go

+		return nil, currency.ErrCurrencyPairEmpty
+	}
+	if p.Side == "" {
+		return nil, errSideEmpty


Replace this with order.ErrSideIsInvalid

samuael · 2025-10-27T18:58:40Z

exchanges/bitget/bitget.go

+		return nil, errSideEmpty
+	}
+	if p.OrderType == "" {
+		return nil, errOrderTypeEmpty


can be order.ErrUnsupportedOrderType or order.ErrTypeIsInvalid

samuael · 2025-10-27T19:01:13Z

exchanges/bitget/bitget.go

+		return nil, errStrategyEmpty
+	}
+	if p.OrderType == "limit" && p.Price <= 0 {
+		return nil, errLimitPriceEmpty


replace with order.ErrPriceMustBeSetIfLimitOrder

samuael · 2025-10-27T19:12:59Z

exchanges/bitget/bitget.go

+func (e *Exchange) GetUnfilledOrders(ctx context.Context, pair currency.Pair, tpslType string, startTime, endTime time.Time, limit, pagination, orderID int64, acceptableDelay time.Duration) ([]UnfilledOrdersResp, error) {
+	var params Params
+	params.Values = make(url.Values)
+	err := params.prepareDateString(startTime, endTime, true, true)


shorten this too if err := ....

samuael · 2025-10-27T19:16:49Z

exchanges/bitget/bitget.go

+	errSideEmpty                      = fmt.Errorf("%w: empty order side", order.ErrSideIsInvalid)
+	errOrderTypeEmpty                 = fmt.Errorf("%w: empty order type", order.ErrTypeIsInvalid)
+	errStrategyEmpty                  = errors.New("strategy cannot be empty")
+	errLimitPriceEmpty                = fmt.Errorf("%w: Price below minimum for limit orders", limits.ErrPriceBelowMin)


replace with order.ErrPriceMustBeSetIfLimitOrder

samuael

Shalooom 🕊️ brother.
Just added another round of review on endpoint functions.

samuael · 2025-11-11T20:09:48Z

exchanges/bitget/bitget.go

+// QueryAnnouncements returns announcements from the exchange, filtered by type and time
+func (e *Exchange) QueryAnnouncements(ctx context.Context, annType string, startTime, endTime time.Time, pagination uint64, limit uint8) ([]AnnouncementResp, error) {
+	var params Params
+	params.Values = make(url.Values)


move this to below the error check.

That can't be done; the error check calls a function on params which operates on params.Values

samuael · 2025-11-11T20:13:13Z

exchanges/bitget/bitget.go

+	}
+	vals := url.Values{}
+	vals.Set("businessType", businessType)
+	var resp []AllTradeRatesResp


can use []* for all response type declarations from now on; for consistency.
Instead of iterating over a slice and use the index to access elements, we can iterate over the slice but use the pointer and reduce the memory overhead.

In both cases you'd be putting the underlying data into memory at one point, being a slice of pointers just requires you to keep track of the pointer as well, which is more memory and more work for the GC!

samuael · 2025-11-11T20:15:09Z

exchanges/bitget/bitget.go

+// GetSpotTransactionRecords returns the user's spot transaction records
+func (e *Exchange) GetSpotTransactionRecords(ctx context.Context, cur currency.Code, startTime, endTime time.Time, limit, pagination uint64) ([]SpotTrResp, error) {
+	var params Params
+	params.Values = make(url.Values)


Could you move this declaration below the error checks?
Apply to all occurences in this PR. always, params declaration after all the error checks pass.

samuael · 2025-11-11T20:15:26Z

exchanges/bitget/bitget.go

+// GetFuturesTransactionRecords returns the user's futures transaction records
+func (e *Exchange) GetFuturesTransactionRecords(ctx context.Context, productType string, cur currency.Code, startTime, endTime time.Time, limit, pagination uint64) ([]FutureTrResp, error) {
+	var params Params
+	params.Values = make(url.Values)


samuael · 2025-11-11T20:16:23Z

exchanges/bitget/bitget.go

+	if pagination > 0 {
+		params.Values.Set("idLessThan", strconv.FormatUint(pagination, 10))
+	}
+	var resp []P2PTrResp


Suggested change

var resp []P2PTrResp

var resp []*P2PTrResp

samuael · 2025-11-11T20:18:24Z

exchanges/bitget/bitget.go

+	}
+	vals := url.Values{}
+	vals.Set("symbol", pair.String())
+	vals.Set("period", period)


period is not checked.

I only check for zero values in cases where zero values cause issues with the way the exchange responds.

samuael · 2025-11-11T20:19:03Z

exchanges/bitget/bitget.go

+	}
+	vals := url.Values{}
+	vals.Set("symbol", pair.String())
+	vals.Set("period", period)


period is not checked for zero value

samuael · 2025-11-11T20:19:44Z

exchanges/bitget/bitget.go

+	if period != "" {
+		vals.Set("period", period)
+	}
+	vals.Set("coin", cur.String())


cur is not checked if it is zero value.

samuael · 2025-11-11T20:21:23Z

exchanges/bitget/bitget.go

+		return nil, errSubaccountEmpty
+	}
+	path := bitgetUser + bitgetCreate + bitgetVirtualSubaccount
+	req := struct {


Suggested change

req := struct {

req := map[string][]string{"subAccountList": subaccounts}

samuael · 2025-11-11T20:31:45Z

exchanges/bitget/bitget.go

+	vals := url.Values{}
+	vals.Set("symbol", pair.String())
+	vals.Set("precision", precision)
+	vals.Set("limit", limit)


Why are these variables not being checked for zero value?

shazbert

Will start to integrate this as priority and will help out with any changes

shazbert · 2025-11-19T00:21:24Z

exchanges/bitget/bitget_wrapper.go

+		Unsubscriber:                           e.Unsubscribe,
+		GenerateSubscriptions:                  e.generateDefaultSubscriptions,
+		Features:                               &e.Features.Supports.WebsocketCapabilities,
+		MaxWebsocketSubscriptionsPerConnection: 240,


Suggested change

MaxWebsocketSubscriptionsPerConnection: 240,

MaxWebsocketSubscriptionsPerConnection: 1000,

A single connection can subscribe up to 1000 Streams;
See: https://bitgetlimited.github.io/apidoc/en/spot/#overview

Also please use multi-connection management for future scaling options see: #2109
Will add a diff or push to branch if I can get around to it before you come back.

…per docs

…efault subs

shazbert

Have updated accounts which needs more testing, migrated to multi-connection and added some fixes to subs. On login for the private conn it waits until it has a confirmation message.

Some things that need to be addressed:

futures asset needs to be broken up to USDT margined, USDC margined and Coin Margined futures.
margin and cross margin subs are semi broken
linter/misc/spell needs fixing
bitget config needs to be added to config_example.json

Will keep pushing things as I came across them. 🚀

shazbert · 2025-11-20T02:06:43Z

exchanges/bitget/bitget.go

+
+// QueryAnnouncements returns announcements from the exchange, filtered by type and time
+func (e *Exchange) QueryAnnouncements(ctx context.Context, annType string, startTime, endTime time.Time, pagination uint64, limit uint8) ([]AnnouncementResp, error) {
+	var params Params


suggestion: Params type can have url.Values unexported and then just have methods to the underlying which calls make when there is a nil reference, stops you having to do params.Values = make(url.Values)

I think I found a better way to do this.

…dling, plus todos

- Added websocket support for placing spot and futures orders with validation checks. - Implemented cancellation of orders via websocket for both spot and futures. - Created request and response types for websocket interactions. - Added tests for websocket order submission and cancellation to ensure proper functionality. - Updated order types to include settlement currency for derivatives.

github-actions · 2025-12-19T00:01:24Z

This PR is stale because it has been open 21 days with no activity. Please provide an update on the progress of this PR.

cranktakular added 30 commits March 8, 2024 11:25

Initial bitget setup

3cf6d96

Bitget progress

eb73fa6

Bitget progress

57e5831

Bitget progress

eea7fd4

Bitget day 1 done

c207678

Bitget progress

6146817

Bitget progress

542c63f

Bitget progress and refinement

9156c0d

Bitget mid-day progress

e8b8b94

More bitget progress

a89c8cb

Merge branch 'master' into bitget_api_creation

19a3914

Yet more Bitget progress

ed133cf

Bitget progress and number expansion

5bc2a31

Mid-day bitget progress

7dd89c4

Another day, another Bitget

361a5f1

Daily Bitget Progress

850291e

Bitget progression

51958ce

Continual Bitget progress

d7faf68

Bitget blitzing

6c8afd5

Bitget progress, REST almost done

dc8f87f

Bitget progress

c44723a

Bitget progress

7904cde

Little bit of bitget progress

c30bfe6

New endpoints & generic experiments

b8d2295

Small fixes

36145f9

Bitget progress

05341f7

Merge branch 'master' into bitget_api_creation

8f55806

One xeno's paradox of progress

f3b6b00

Bitget building

21116ac

A bitget commit

f482c05

thrasher- added this to GoCryptoTrader Kanban Sep 23, 2025

thrasher- moved this to In review in GoCryptoTrader Kanban Sep 23, 2025

Fixes post-merge issues / Corrects issues identified by review / Fixe…

b331ef8

…s discovered exchange-side errors

shazbert requested changes Sep 24, 2025

View reviewed changes

cranktakular added 2 commits September 30, 2025 16:19

Applies changes requested by shazbert

6687801

Applies another batch of changes requested by shazbert

2e8533b

samuael reviewed Oct 12, 2025

View reviewed changes

samuael reviewed Oct 14, 2025

View reviewed changes

samuael suggested changes Oct 27, 2025

View reviewed changes

cranktakular added 3 commits October 28, 2025 14:02

Implements some requested changes

f1d1203

Implements more requested changes

8ac4844

Implements even more requested changes

de588f6

samuael reviewed Nov 11, 2025

View reviewed changes

shazbert requested changes Nov 19, 2025

View reviewed changes

Ryan O'Hara-Reid added 8 commits November 19, 2025 13:44

Increases MaxWebsocketSubscriptionsPerConnection from 240 to 1000 as …

e3f60df

…per docs

Merge branch 'master' into bitget_api_creation

622d654

bitget: after merge update for accounts and futures

a365501

linter: fix some issues

63bb7ce

bitget: fix tests and refactor

ae0e42e

bitget: use internal orderbook type to reduce code footprint

dd29640

bitget: migrate to websocket multi-connection

ea08521

bitget: link up config subs with subscription expansion, enable all d…

8b7afe9

…efault subs

shazbert requested changes Nov 20, 2025

View reviewed changes

Ryan O'Hara-Reid and others added 3 commits November 24, 2025 10:17

biget: fix fetch tradable pairs for futures, and update execution han…

a8dcfe7

…dling, plus todos

Implements requested changes, fixes bugs

1875eb9

shazbert pushed a commit to shazbert/gocryptotrader that referenced this pull request Dec 11, 2025

bitget_api_creation: thrasher-corp#1844

b34968f

github-actions bot added the stale label Dec 19, 2025

github-actions bot removed the stale label Jan 26, 2026

	err := params.prepareDateString(startTime, endTime, false, false)
	if err := params.prepareDateString(startTime, endTime, false, false); err != nil {

	req := struct {
	req := map[string][]string{"subAccountList": subaccounts}

	MaxWebsocketSubscriptionsPerConnection: 240,
	MaxWebsocketSubscriptionsPerConnection: 1000,

Bitget: Add exchange support #1844

Are you sure you want to change the base?

Bitget: Add exchange support #1844

Uh oh!

Conversation

cranktakular commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

Type of change

How has this been tested

Checklist

Uh oh!

shazbert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

samuael left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cranktakular Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

samuael left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

samuael left a comment

Choose a reason for hiding this comment

cranktakular commented Mar 10, 2025 •

edited

Loading

cranktakular Oct 28, 2025 •

edited

Loading