Skip to content

Conversation

@cholcombe973
Copy link

This addresses #18 and breaks the sensu module out into its own library. I also fixed some clippy lints along the way. I didn't run rustfmt over the code because it would change too many lines and make it hard to see what I changed.

@cholcombe973
Copy link
Author

@jbaublitz any thoughts on this?

@jbaublitz
Copy link
Contributor

@cholcombe973 Hi! I no longer have push access for this repository so I'm unable to merge this, but I took a look at the changes and it seems reasonable at first glance based on the issue you opened. I want to review further before signing off on this, but I'm cc'ing @patcable so he can also provide feedback. He still can get this merged if we decide it ultimately makes sense.

@patcable
Copy link
Contributor

Hey @cholcombe973! Thanks for taking a look at this. (And, thanks friend-of-the-stack @jbaublitz for pinging me)

One of the reasons we put the code up here but didn't do much with publishing on Crates is because we don't have a lot of rust stuff right now. If you're cool with the refactor living here, I'm cool with merging this in - I'm also happy if folks fork and then publish to crates too.

@cholcombe973
Copy link
Author

@patcable yeah I'm fine with it living here.

@jbaublitz
Copy link
Contributor

@patcable After looking into this a little more, I'd like to do one more thing before we merge this and make a new crate. Sensu has released a new API.

@cholcombe973 Any objections if I add your commits to a larger PR supporting both legacy and new Sensu APIs? Then I'm happy to release this as a standalone.

@cholcombe973
Copy link
Author

@jbaublitz no objections :). Feel free

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants