Skip to content

Fix ComputeBuiltinNode typings for vector builtins (uvec3 swizzles) #2045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Methuselah96 merged 2 commits into from
Feb 21, 2026
Merged

Fix ComputeBuiltinNode typings for vector builtins (uvec3 swizzles) #2045

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
187a3c1
Update ComputeBuiltinNode.d.ts: expose coordinates
thelazylamaGit Feb 20, 2026
f7a1a8a
Make ComputeBuiltinNode generic
Methuselah96 Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions types/three/src/nodes/gpgpu/ComputeBuiltinNode.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,22 @@
import Node from "../core/Node.js";
import { NodeBuilder } from "../Nodes.js";

declare class ComputeBuiltinNode extends Node {
constructor(builtinName: string, nodeType: string);
interface ComputeBuiltinNodeInterface {
setBuiltinName(builtinName: string): this;
getBuiltinName(builder: NodeBuilder): string;
hasBuiltin(builder: NodeBuilder): boolean;
}

declare const ComputeBuiltinNode: {
new<TNodeType>(builtinName: string, nodeType: TNodeType): ComputeBuiltinNode<TNodeType>;
};

type ComputeBuiltinNode<TNodeType = unknown> = Node<TNodeType> & ComputeBuiltinNodeInterface;

export default ComputeBuiltinNode;

export const numWorkgroups: ComputeBuiltinNode;
export const workgroupId: ComputeBuiltinNode;
export const globalId: ComputeBuiltinNode;
export const localId: ComputeBuiltinNode;
export const subgroupSize: ComputeBuiltinNode;
export const numWorkgroups: ComputeBuiltinNode<"uvec3">;
export const workgroupId: ComputeBuiltinNode<"uvec3">;
export const globalId: ComputeBuiltinNode<"uvec3">;
export const localId: ComputeBuiltinNode<"uvec3">;
export const subgroupSize: ComputeBuiltinNode<"uint">;