Skip to content

Don't include stub contracts in NPM packages #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michalinacienciala wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't include stub contracts in NPM packages #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/contracts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ jobs:
run: yarn install --frozen-lockfile

- name: Deploy contracts
run: yarn deploy:test
run: yarn deploy:local

contracts-deployment-testnet:
needs: [contracts-build-and-test]
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/npm-contracts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ jobs:
@keep-network/tbtc

# Deploy contracts to a local network to generate deployment artifacts that
# are required by dashboard compilation.
# are required by client compilation.
- name: Deploy contracts
run: yarn deploy:test --network hardhat --write true
run: yarn deploy:local --network hardhat --write true

- name: Bump up package version
id: npm-version-bump
Expand Down
2 changes: 1 addition & 1 deletion solidity/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"clean": "hardhat clean && rm -rf cache/ export/ external/npm export.json",
"build": "hardhat compile",
"deploy": "hardhat deploy --export export.json",
"deploy:test": "USE_EXTERNAL_DEPLOY=true TEST_USE_STUBS_TBTC=true hardhat deploy",
"deploy:local": "USE_EXTERNAL_DEPLOY=true hardhat deploy",
"format": "npm run lint && prettier --check .",
"format:fix": "npm run lint:fix && prettier --write .",
"lint": "npm run lint:eslint && npm run lint:sol",
Expand Down