Skip retry for registered wallets#816
Open
ptdatta wants to merge 2 commits intothreshold-network:mainfrom
Open
Skip retry for registered wallets#816ptdatta wants to merge 2 commits intothreshold-network:mainfrom
ptdatta wants to merge 2 commits intothreshold-network:mainfrom
Conversation
Signed-off-by: Parthib Datta <parthibdutta02@gmail.com>
Member
|
Thanks for this @ptdatta! Giving it a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #815
The
backoffRetrierruns retry for every error which makes the redemption process takes a long time.So for registered wallets, it should not retry so instead of
retryAllwe useskipRetryWhenMatched["Wallet with the given ID has not been registered"]so that it skips retry for registered wallets.