feat: replace ethers v5 with @ethersproject modules#924
Open
DefiCake wants to merge 1 commit intothreshold-network:mainfrom
Open
feat: replace ethers v5 with @ethersproject modules#924DefiCake wants to merge 1 commit intothreshold-network:mainfrom
DefiCake wants to merge 1 commit intothreshold-network:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This increases compatibility of the npm package with other projects that might be using different ethers versions.
The monolithic
ethersv5 package should be used in final projects; for libraries and SDKs, it is ill advised because it will cause problems during dependency resolution.As a note, I had to also add a git resolution in the typescript
package.jsonbecause my yarn setup would fail when fetching it. Feel free to fork this branch and remove that change if it is not suitable for your needs.