Attempt at Py3 compatibility #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can find no references to DNS in the source code. Fixes thruflo#8
This at least fixes the import issue. I have blocked on pyramid-simpleform being 5 years out of date on PyPi, though it appears to be fixed on GitHub.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes several changes:
At least one dependency (pyramid_simpleform) is 5 years out of date on PyPi, so it doesn't support Py3. Though it appears fine in the current master on github.
pyramid_basemodel generate_random_digest also needs a small change for py3 support. so does pyramid_simpleauth\model.py . (Both should use bytes, not unicode.)
passlib has supported python3 for some time now, that does not appear to cause issues..
I'm going to stop here, but for the next person who attempts this they'll have less work to do.