Improve nightly E2E test suite authentication issues in BrowserStack #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwood-moz
force-pushed
the
testing/improve-e2e
branch
from
92ca0fb to
7ad5cdf
Compare
rwood-moz
force-pushed
the
testing/improve-e2e
branch
from
7ad5cdf to
5a6615c
Compare
rwood-moz
force-pushed
the
testing/improve-e2e
branch
from
5a6615c to
d2818fe
Compare
rwood-moz
force-pushed
the
testing/improve-e2e
branch
from
d2818fe to
c29176d
Compare
rwood-moz
force-pushed
the
testing/improve-e2e
branch
from
c29176d to
fe26525
Compare
rwood-moz
force-pushed
the
testing/improve-e2e
branch
from
fe26525 to
2f3da8a
Compare
rwood-moz
force-pushed
the
testing/improve-e2e
branch
from
2f3da8a to
f401580
Compare
rwood-moz
force-pushed
the
testing/improve-e2e
branch
from
f401580 to
c9895e6
Compare
rwood-moz
changed the title
MelissaAutumn
approved these changes
Dec 5, 2025
Member
MelissaAutumn
left a comment
MelissaAutumn
left a comment
There was a problem hiding this comment.
Looks fine to me, thank you!
I wonder if we can eventually figure out a wait to remove all these waits, seems like a lot of unfortunate busy work 😅.
| constructor(page: Page) { | ||
| this.page = page; | ||
| this.signInHeaderText = this.page.getByText('Enter your password'); | ||
| this.signInHeaderText = this.page.getByText('Sign in to your account'); |
Member
There was a problem hiding this comment.
I wonder if we can just hook into the localization file for appointment and then call it by the l10n key.
...sorry just thinking ahead, no action for this PR 😄
Contributor
Author
Yes that would be ideal, but unfortunately the timing is different on local vs stage vs prod vs mobile (especially slower in BrowserStack), so it's pretty tricky. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1369: Restructure the nightly E2E test suite into multiple BrowserStack sessions to fix authentication issues. Also adds a check at the start of each test in case the Appointment session has timed out, then it will log in again and save the auth state before the test starts. This is still not foolproof in that the Appointment sign in session might expire during a test and then the test would fail, however in that case the very next test would sign in again.
BrowserStack links here for desktop tests and mobile tests on stage.