Override Tailwind's Input pre-applied styles #1397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Upstream changes were made that is now affecting our components coming from
services-uiwhen being used in a Tailwind context. There is a combination of background, border and padding that is being applied that makes some of the input types to mismatch our current UI mockups.It would be great if we could spare some time to completely remove Tailwind as this issue suggests but there are quite a few references in the code base to Tailwind classes that would require care.
The problem can currently be seen in
stagein screens like the Availability page, for example: https://appointment-stage.tb.pro/availability. This does not happen in production yet as production is a bit behind.For now, this PR only touches the affected input types to remove Tailwind's styles.
Screenshots
Before / Login modal (AUTH_SCHEME=password)

After / Login modal (AUTH_SCHEME=password)

Before / Availability Page

After / Availability Page

Benefits
Back to cohesive styles for inputs!
How to test
AUTH_SCHEMEin thefrontend/.envfile ispassword, check that the password input matches the username input.AUTH_SCHEMEin thefrontend/.envfile isoidc, check that the FTUE doesn't show any mismatching styles, specially around the Availability step (the time inputs had mismatching UI)Availabilitypage for any mismatching UI input.Applicable Issues
Fixes #1396