Fix UserAvatar should link back to TB Accounts #1401
Conversation
devmount
left a comment
devmount
left a comment
There was a problem hiding this comment.
I found one issue probably caused by the services-ui TextInput component. Can you check if this is the case? I can fix that component if applicable.
| </label> | ||
| <div class="booking-page-url-input-container"> | ||
| <text-input name="booking-page-url" class="booking-page-input" v-model="userStore.myLink" /> | ||
| <text-input name="booking-page-url" class="booking-page-input" v-model="userStore.myLink" readonly /> |
There was a problem hiding this comment.
For some reason, this doesn't work on my end. It adds a readonly attribute on the label, not on the input... we might need to check services-ui for this issue.
I can still edit that input and get some error messages doing so:
There was a problem hiding this comment.
Oh interesting! Here, the readonly attribute seems to be applied both to the label and the input itself for me 🤔 Even after you rebuild the containers with a docker compose up -d --build it still shows the error? I've deleted my containers just in case and it still works for me
| // verify all expected router-link child components were rendered when signed in and menu is now shown | ||
| const expectedLinks = [ | ||
| 'dashboard', // there are two dashboard rounter-link child components | ||
| 'dashboard', // there are two dashboard router-link child components |
devmount
left a comment
devmount
left a comment
There was a problem hiding this comment.
Oh and the user avatar has no href on my end. But I guess I need a corresponding .env entry for TB accounts, right?
@devmount ah yes, I forgot to add this to the instructions in the PR, good catch! It needs a |
devmount
left a comment
devmount
left a comment
There was a problem hiding this comment.
Ohh you're right! I did npm install but didn't restart the frontend container. Now everything works like a charm! Thanks!
Ah thanks for adding that env var, the link is now there too. Nothing to complain about anymore 😂 Thanks for the great work, approved!
2 participants
Description of the Change
UserAvatarand made it a link to TB Accounts' Dashboard instead per the issue descriptionUserAvatarin the NavBar to match Zeplinservices-uito1.4.3input[type="email]in the Booker's page (Tailwind upstream issues residue)ProfileViewroute + component as it is now unreachable (it was present in the drop-down only)readonlyNote
Please update the
frontend/.envfile to includeVITE_TB_ACCOUNT_DASHBOARD_URL=https://accounts.tb.pro/dashboardif you don't have it set to anything else.Screenshots
Before / NavBar
After / NavBar
Benefits
Applicable Issues
Fixes #1388