Skip to content

Conversation

@davinotdavid
Copy link
Contributor

Description of the Change

  • Removed the "Zoom banner" / "Beta Warning". Note that this also removes quite a bit of extra code that could be useful in the future but was unused except for this beta warning (UserActivityStore and related). In case we need to add dismisable warnings we can refer back to this PR and re-add it!

Benefits

  • Less user confusion around being beta / not beta as it does not reflect the limitation we had before
  • Better mobile experience as the banner took quite a bit of space in the dashboard

Applicable Issues

Fixes #1382

Copy link
Contributor

@rwood-moz rwood-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to remove the underlying code for dismisable warnings (even though it can be added back)? One example use I can maybe see is if we ever need to plan some downtime for maintenance.

@davinotdavid
Copy link
Contributor Author

davinotdavid commented Jan 7, 2026

Are you sure you want to remove the underlying code for dismisable warnings (even though it can be added back)? One example use I can maybe see is if we ever need to plan some downtime for maintenance.

@rwood-moz That's a good point, I agree that this is very likely to make a come back. It is either a question of leaving unused / dead code in the code base for the potential use in the future or having only reachable code.

IMHO it is a small lift to re-add it if needed and I'd prefer to reduce code when we can if not used but I'm also ok to keep it if you all prefer since it is a small change anyways.

@rwood-moz
Copy link
Contributor

@rwood-moz That's a good point, I agree that this is very likely to make a come back. It is either a question of leaving unused / dead code in the code base for the potential use in the future or having only reachable code.

IMHO it is a small lift to re-add it if needed and I'd prefer to reduce code when we can if not used but I'm also ok to keep it if you all prefer since it is a small change anyways.

I'm fine with whatever you think is best. Either way, I tried out your branch locally, went through the FTUE, and didn't see the banner anymore after navigating to the dashboard. Awesome!

Copy link
Collaborator

@devmount devmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Davi. I'm fine with deleting everything, it's actually quite a lot for one banner, if I think about it 😅

@davinotdavid davinotdavid merged commit 6f6027d into main Jan 7, 2026
8 checks passed
@davinotdavid davinotdavid deleted the remove-dashboard-zoom-banner branch January 7, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the "connecting Zoom accounts" banner text to reflect current app approval status.

3 participants