Update settings E2E tests for settings page UI overhaul #1434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwood-moz
force-pushed
the
settings-ui-overhaul-e2e
branch
from
dbe100b to
ae2829a
Compare
rwood-moz
force-pushed
the
settings-ui-overhaul-e2e
branch
from
ae2829a to
30a9b78
Compare
rwood-moz
force-pushed
the
settings-ui-overhaul-e2e
branch
from
30a9b78 to
6da44a0
Compare
rwood-moz
changed the title
davinotdavid
approved these changes
Jan 16, 2026
Contributor
davinotdavid
left a comment
davinotdavid
left a comment
There was a problem hiding this comment.
LGTM overall! Thanks for updating the tests! Just some non-blocking couple of questions for my curiosity.
rwood-moz
force-pushed
the
settings-ui-overhaul-e2e
branch
from
6da44a0 to
f815b73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1428. Update the settings E2E tests so they work again after the settings page UI overahaul (#1425).
BrowserStack links running the updated tests on: