Fix OIDC token instrospection redis_instance args#1451
Merged
davinotdavid merged 1 commit intomainfrom Jan 21, 2026
Merged
Conversation
MelissaAutumn
approved these changes
Jan 20, 2026
Member
MelissaAutumn
left a comment
There was a problem hiding this comment.
Looks good, I'd rather we resolve the dependency for redis_instance if it isn't already, but we can cut a future ticket for that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
get_subscriberdirectly, we are not going through the FastAPI DI so theredis_instanceis actually aDependsobject. Added theredis_instanceto the calls toget_subscriberso that it actually works now.redis_instance = Noneinstead so we fail gracefully and just don't use the caching at all for the token introspection (and added tests).Benefits
get_subscriberwithout passing aredis_instancefrom the FastAPI DI.Applicable Issues
Fixes #1448