Update desktop & mobile NavBar's UserAvatar menu#1452
Merged
davinotdavid merged 6 commits intomainfrom Jan 22, 2026
Merged
Conversation
davinotdavid
had a problem deploying
to
staging
GitHub Actions
Failure
davinotdavid
force-pushed
the
update-header-nav-user-avatar-menu
branch
from
fcafbda to
223a3d5
Compare
davinotdavid
requested review from
MelissaAutumn,
devmount and
rwood-moz
and removed request for
devmount and
rwood-moz
Member
|
This looks good! I wonder if we should move it as a pattern in services-ui though 🤔 |
Member
|
I'll review this as-is right now, and we can cut a ticket for moving it to services-ui for shared use. |
Contributor
Author
|
@MelissaAutumn oh indeed it makes sense for it to become a pattern in |
rwood-moz
approved these changes
Jan 22, 2026
Contributor
rwood-moz
left a comment
rwood-moz
left a comment
There was a problem hiding this comment.
Looks good, and works great when I tried it locally.
MelissaAutumn
approved these changes
Jan 22, 2026
Member
MelissaAutumn
left a comment
MelissaAutumn
left a comment
There was a problem hiding this comment.
Looks good, for another issue though we'll want to figure out why logout isn't asking for user confirmation.
Contributor
Author
|
Thanks for the reviews @rwood-moz and @MelissaAutumn ! Opened up an issue for prompting a logout confirmation #1456 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
useTimeAgoIntlcomposable during the render in the Dashboard could cause a render error since we might not yet have fetched the user dataReportBugview and related files since we are prioritizing the contact form for issues and the route is no longer accessible from anywhere (last place was the mobile navigation)Note
If you haven't already, you need
VITE_TB_ACCOUNT_DASHBOARD_URLandVITE_SUPPORT_URLenv vars set!Screenshots
Desktop (Light mode)
Desktop (Dark mode)
Mobile (Light mode)
Mobile (Dark mode)
Benefits
Applicable Issues
Fixes #1409