Update all stage services to have stage names#632
Merged
Conversation
MelissaAutumn
approved these changes
Mar 9, 2026
Member
MelissaAutumn
left a comment
MelissaAutumn
left a comment
There was a problem hiding this comment.
Ah good catch. Maybe in the future we can have pulumi automagically append the -${env} to a given name...although that might get confusing too.
Thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we leave off the
-stageparts of our resource names, we wind up with conflicts between environments. The permissions model in this system is actually designed to want the specification. So here I changed all of the references to services like "celery" and "flower" to "celery-stage" and "flower-stage".