Conversation
2a574e0 to
327c54e
Compare
| @@ -903,4 +915,3 @@ resources: | |||
| - arn:aws:iam::768512802988:role/accounts-stage-fargate-keycloak | |||
| - arn:aws:iam::768512802988:role/accounts-stage-afc-accounts-celery-stage | |||
| - arn:aws:iam::768512802988:role/accounts-stage-afc-accounts-flower-stage | |||
Member
There was a problem hiding this comment.
Did I break this in the rebase fix? It was without the env at the end.
Contributor
Author
There was a problem hiding this comment.
I'm not certain if/where it broke. There was a point when I did not use the env name suffix, but we definitely need it now. I will pull your changes and do a quick pulumi preview to see if anything odd is there. brb
MelissaAutumn
approved these changes
Mar 10, 2026
Member
MelissaAutumn
left a comment
There was a problem hiding this comment.
Looks good, but prod changes will cause no sentry traces to be sent. Might want to correct that.
Contributor
Author
|
I ran these task definition changes out to the environment. When the new code gets deployed, the settings should be there to take effect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few things are present in this PR, all related to our stage environment:
SENTRY_TRACES_SAMPLE_RATE, which defaults to0.0. This value should be afloatbetween0.0and1.0indicating a percentage of application traces to send to Sentry. At1.0, this is 100% of all traces (which can be a lot).FLOWER_UNAUTHENTICATED_APIin Flower, which makes the UI fully functional. This is discouraged, and we don't have auth set up here, but it should be okay since we have to have infra-level permissions to build a bastion to SSH proxy our way in. We should revisit this auth later in the context of other queue functions we have and the idea we've been throwing around of setting up a central Keycloak auth server for corporate systems.uv run ruff format, which produced a number of lint updates.