Skip to content

A series of fixes in stage#635

Merged
ryanjjung merged 16 commits intomainfrom
stage-fixes
Mar 11, 2026
Merged

A series of fixes in stage#635
ryanjjung merged 16 commits intomainfrom
stage-fixes

Conversation

@ryanjjung
Copy link
Contributor

@ryanjjung ryanjjung commented Mar 10, 2026

A few things are present in this PR, all related to our stage environment:

  • Added back some environment secrets that had been inadvertently removed, leading to database connection errors.
  • Removed some instructions in the readme that I suspect are old because they have been resolved in the compose file and doing what the readme says actually breaks my local dev setup.
  • Added instructions to the readme on accessing the Flower web interface.
  • Updated the compose file to include some file watches on the accounts service since testing changes to my env was otherwise quite slow.
  • Added a new optional environment variable called SENTRY_TRACES_SAMPLE_RATE, which defaults to 0.0. This value should be a float between 0.0 and 1.0 indicating a percentage of application traces to send to Sentry. At 1.0, this is 100% of all traces (which can be a lot).
  • Updated stage services to define different trace sample rates, trying to quiet some of the health check noise from Flower.
  • Enabled FLOWER_UNAUTHENTICATED_API in Flower, which makes the UI fully functional. This is discouraged, and we don't have auth set up here, but it should be okay since we have to have infra-level permissions to build a bastion to SSH proxy our way in. We should revisit this auth later in the context of other queue functions we have and the idea we've been throwing around of setting up a central Keycloak auth server for corporate systems.
  • Out of habit, I ran a uv run ruff format, which produced a number of lint updates.

@@ -903,4 +915,3 @@ resources:
- arn:aws:iam::768512802988:role/accounts-stage-fargate-keycloak
- arn:aws:iam::768512802988:role/accounts-stage-afc-accounts-celery-stage
- arn:aws:iam::768512802988:role/accounts-stage-afc-accounts-flower-stage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I break this in the rebase fix? It was without the env at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not certain if/where it broke. There was a point when I did not use the env name suffix, but we definitely need it now. I will pull your changes and do a quick pulumi preview to see if anything odd is there. brb

@ryanjjung ryanjjung marked this pull request as ready for review March 10, 2026 19:58
@ryanjjung ryanjjung requested a review from MelissaAutumn March 10, 2026 19:58
Copy link
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but prod changes will cause no sentry traces to be sent. Might want to correct that.

@ryanjjung
Copy link
Contributor Author

I ran these task definition changes out to the environment. When the new code gets deployed, the settings should be there to take effect.

@ryanjjung ryanjjung merged commit 592208a into main Mar 11, 2026
8 checks passed
@ryanjjung ryanjjung deleted the stage-fixes branch March 11, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants