Further improvements to our third-party payment processor flow.#639
Merged
MelissaAutumn merged 4 commits intomainfrom Mar 16, 2026
Merged
Further improvements to our third-party payment processor flow.#639MelissaAutumn merged 4 commits intomainfrom
MelissaAutumn merged 4 commits intomainfrom
Conversation
* Brings back successUrl and the backend route * If the payment type was Paypal (or another pop-up window based type) then redirect them to a window.close template. * If the payment was not a pop-up window based type simply redirect them. * Added and enhanced plenty of structural window timeouts -.-.
Contributor
davinotdavid
left a comment
davinotdavid
left a comment
There was a problem hiding this comment.
Other than the tests that seems to be require updating, lgtm!
…nd remove the dev only call for checking paddle directly.
Member
Author
|
Okay tests are fixed, coverage of the code isn't ideal but I need to look into effective ways of testing session data in the future... I've also refactored how the complete and polling functions work, so dev should work almost exactly like stage/prod. |
davinotdavid
approved these changes
Mar 12, 2026
Contributor
davinotdavid
left a comment
davinotdavid
left a comment
There was a problem hiding this comment.
lgtm! I've tested locally with the PayPal Sandbox account in 1Password, and with the normal card payment and it works well 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue #458
I discovered a weird issue with new accounts and the csrftoken, but I need to test on stage to make sure I'm not chasing a weird dev issue.