Skip to content

Don't enable payment verification mode if they already have a sub (Fixes #642)#644

Merged
MelissaAutumn merged 1 commit intomainfrom
bugs/642-fix-race-condition
Mar 17, 2026
Merged

Don't enable payment verification mode if they already have a sub (Fixes #642)#644
MelissaAutumn merged 1 commit intomainfrom
bugs/642-fix-race-condition

Conversation

@MelissaAutumn
Copy link
Member

Fixes #642

During the Paypal checkout there's a chance the Paypal side can take longer than Paddle's webhook send & processing. So if we already digest and process the Paddle webhook (which would flip has_active_subscription to True) then we should be sure that we're not reverting a step on the redirect response.

@MelissaAutumn MelissaAutumn self-assigned this Mar 17, 2026
Copy link
Contributor

@davinotdavid davinotdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@MelissaAutumn MelissaAutumn merged commit d706c7c into main Mar 17, 2026
8 checks passed
@MelissaAutumn MelissaAutumn deleted the bugs/642-fix-race-condition branch March 17, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paddle paypal subscription did not remove payment verification status

2 participants