Open
Conversation
wmontwe
force-pushed
the
remaining-utf-bits
branch
from
38b9e53 to
221eb96
Compare
Member
|
@arnt I updated the pr, we already use MIME4J 0.8.13. Thank you for the update! |
wmontwe
requested changes
Nov 3, 2025
mail/common/src/main/java/com/fsck/k9/mail/helper/Rfc822Token.java
Outdated
Show resolved
Hide resolved
rafaeltonholo
previously approved these changes
Nov 3, 2025
| @@ -202,4 +203,13 @@ public boolean equals(@Nullable Object o) { | |||
| stringEquals(mAddress, other.mAddress) && | |||
| stringEquals(mComment, other.mComment)); | |||
| } | |||
|
|
|||
| public static String withULabelDomain(final String address) { | |||
Member
There was a problem hiding this comment.
Please consider adding @Nullable to the method and to the parameter as well.
Suggested change
| public static String withULabelDomain(final String address) { | |
| @Nullable | |
| public static String withULabelDomain(final @Nullable String address) { |
An header such as From: info@xn--gr-zia.org is syntax according to RFCs 822 and 5322, but should not be shown to users because the "xn--gr-zia" is as user-unfriendly as it is phisher-friendly. This commit makes Thunderbird morph addresses that used xn-- into the pure unicode form before they can be shown to the user. This also implies that the human-readable form is used in replies.
arnt
force-pushed
the
remaining-utf-bits
branch
from
6fe9d6b to
c0e0798
Compare
Contributor
Author
What! I've looked, and it seems that I rebased on on my laptop and then worked on my normal desktop at home, where I was still on code from the end of July. That implies that this code isn't as thoroughly tested as I thought. Sorry. I'm on the road this week without my test phones. I'm running 'gradle check' now. I'll test properly when I'm home next week. |
rafaeltonholo
added
the
merge block: soft freeze
wmontwe
removed
the
merge block: soft freeze
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains two changes that build on the earlier EAI work and completes the feature.