Skip to content

remove: side rail drawer UI #10163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wmontwe merged 3 commits into from
Dec 9, 2025
Merged

remove: side rail drawer UI #10163

wmontwe merged 3 commits into from
Dec 9, 2025

Conversation

@wmontwe
Copy link
Member

@wmontwe wmontwe commented Nov 27, 2025 •
edited
Loading

Resolves #10073

  • Before merging this, weblate translations need to be updated.

@wmontwe wmontwe requested a review from a team as a code owner November 27, 2025 15:00
@wmontwe wmontwe requested a review from asoucar November 27, 2025 15:00
@wmontwe wmontwe removed the request for review from asoucar November 27, 2025 15:01
@wmontwe wmontwe force-pushed the remove/10073/side-rail-drawer-ui branch from 6bf188f to ce7048d Compare November 27, 2025 16:29
@wmontwe wmontwe added merge block: soft freeze PR to main is blocked: risky code or feature flag enablement must wait until soft freeze lifts. and removed merge block: soft freeze PR to main is blocked: risky code or feature flag enablement must wait until soft freeze lifts. labels Dec 4, 2025
rafaeltonholo
rafaeltonholo previously approved these changes Dec 8, 2025
View reviewed changes
Copy link
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@malteger
Copy link

malteger commented Dec 8, 2025

As the linked issue even states "waiting for release feedback", it would be nice if comments from #10073, #10161, #9568 et al. are addressed instead of just going forward by merging this.

@wmontwe wmontwe force-pushed the remove/10073/side-rail-drawer-ui branch from ce7048d to 5b618cd Compare December 9, 2025 12:16
@wmontwe wmontwe requested a review from rafaeltonholo December 9, 2025 12:17
rafaeltonholo
rafaeltonholo previously approved these changes Dec 9, 2025
View reviewed changes
@wmontwe
remove(drawer): remove remaining siderail ui
e1adbe1 
# Conflicts:
#	feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerView.kt
#	feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/siderail/ui/SideRailDrawerContent.kt
#	feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/siderail/ui/account/SideRailAccountList.kt
#	feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/siderail/ui/account/SideRailAccountView.kt
#	feature/navigation/drawer/dropdown/src/main/kotlin/net/thunderbird/feature/navigation/drawer/siderail/ui/setting/SideRailSettingList.kt
#	feature/navigation/drawer/dropdown/src/test/kotlin/net/thunderbird/feature/navigation/drawer/dropdown/ui/DrawerViewKtTest.kt
@wmontwe
remove(drawer): remove unused strings
17ed259
@wmontwe
remove(drawer): remove enable_dropdown_drawer_ui feature flag
4e1cac6 
# Conflicts:
#	app-k9mail/src/debug/kotlin/app/k9mail/featureflag/K9FeatureFlagFactory.kt
#	app-k9mail/src/release/kotlin/app/k9mail/featureflag/K9FeatureFlagFactory.kt
#	app-thunderbird/src/beta/kotlin/net/thunderbird/android/featureflag/TbFeatureFlagFactory.kt
#	app-thunderbird/src/daily/kotlin/net/thunderbird/android/featureflag/TbFeatureFlagFactory.kt
#	app-thunderbird/src/debug/kotlin/net/thunderbird/android/featureflag/TbFeatureFlagFactory.kt
#	app-thunderbird/src/release/kotlin/net/thunderbird/android/featureflag/TbFeatureFlagFactory.kt
@wmontwe wmontwe force-pushed the remove/10073/side-rail-drawer-ui branch from 5b618cd to 4e1cac6 Compare December 9, 2025 15:39
@wmontwe wmontwe requested a review from rafaeltonholo December 9, 2025 15:40
@wmontwe wmontwe merged commit bd1d74a into thunderbird:main Dec 9, 2025
13 checks passed
@wmontwe wmontwe deleted the remove/10073/side-rail-drawer-ui branch December 9, 2025 16:34
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 17 milestone Dec 9, 2025
@wmontwe
Copy link
Member Author

wmontwe commented Dec 9, 2025

Status update: #9568 (comment)

soopyc added a commit to soopyc/thunderbird-android-with-rail that referenced this pull request Dec 9, 2025
@soopyc
Revert "Merge pull request thunderbird#10163 from wmontwe/remove/1007…
d73279c 
…3/side-rail-drawer-ui"

This reverts commit bd1d74a, reversing
changes made to 79a18ca.

This adds the rail UI back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafaeltonholo rafaeltonholo rafaeltonholo approved these changes

Assignees

@rafaeltonholo rafaeltonholo

Labels

None yet

Projects

None yet

Milestone

Thunderbird 17

Development

Successfully merging this pull request may close these issues.

Remove SideRail Drawer

4 participants

@wmontwe @malteger @rafaeltonholo @asoucar