Don't use deployments when they aren't needed#10725
Open
kewisch wants to merge 1 commit intothunderbird:mainfrom
Open
Don't use deployments when they aren't needed#10725kewisch wants to merge 1 commit intothunderbird:mainfrom
kewisch wants to merge 1 commit intothunderbird:mainfrom
Conversation
coreycb
reviewed
Mar 26, 2026
| environment: publish_hold | ||
| environment: | ||
| name: publish_hold | ||
| deployment: false |
Collaborator
There was a problem hiding this comment.
I think this might need to be true since it has a deployment protection rule.
Member
Author
There was a problem hiding this comment.
From the docs at https://docs.github.com/en/actions/how-tos/deploy/configure-and-manage-deployments/control-deployments#using-environments-without-deployments
When deployment is set to false:
Required reviewers still apply—reviewers must still approve before the job runs.
Collaborator
There was a problem hiding this comment.
Thanks for the link. This will work as-is then. I guess the next question is do we want to have an audit record of deployments for publish hold or not. I think we might want to retain them for security purposes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoiding deployments where not needed. I wasn't sure about shippable builds, I'm not sure we need deployments there at all since we don't use them, but since that is the once spot where we "deploy" something I left some of them as is. Please review where you need deployments.
https://github.blog/changelog/2026-03-19-github-actions-late-march-2026-updates/