Fix: raise swipe velocity threshold to prevent accidental navigation in message viewer#10748
Open
digitalby wants to merge 1 commit intothunderbird:mainfrom
Open
Fix: raise swipe velocity threshold to prevent accidental navigation in message viewer#10748digitalby wants to merge 1 commit intothunderbird:mainfrom
digitalby wants to merge 1 commit intothunderbird:mainfrom
Conversation
Contributor
|
Missing report label. Set exactly one of: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10747
Summary
A single constant change in
MessageViewContainerFragmentraises the velocity threshold forthe swipe-between-messages gesture, preventing fast but unintentional gestures from navigating
to an adjacent email and marking it as read.
The distance threshold (
VIEW_PAGER_SWIPE_THRESHOLD = 0.4f) is unchanged.Notes on the constant value
3.0fis not a final answer. The absolute dp/s value depends on the device. However, this makes accidental velocity-based swipes much harder to trigger. It does not:Those are separate concerns that I've raised an issue about.
Testing
./gradlew :legacy:ui:legacy:test