You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for your uplift request! Please add a comment with the following approval request template filled out.
[Approval Request]
Original Issue/Pull request: #10243/#10771
Regression caused by (issue #): #10366
User impact if declined: The Message List enters a stale state when interacting with the first item of the list, causing user frustration when deleting, marking a message as read, etc.
Testing completed (on daily, beta, etc.): debug
Introduces or modifies localizable strings (yes/no): no
Skips a database migration (yes/no): no
Risk to taking this patch (and alternatives if risky): We will lose any optimization and fixes that may have been introduced on 1.2.0 and above as we are pinning the version, but we will remove that dependency in the near future.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
report: excludeExclude changes from user-facing reports (internal, minor, or not relevant to users).tb-teamTasks and features handled by project maintainers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uplifts #10771 to beta