fix(message): show original sender for Firefox Relay emails#10773
Draft
deckertron9000 wants to merge 1 commit intothunderbird:mainfrom
Draft
fix(message): show original sender for Firefox Relay emails#10773deckertron9000 wants to merge 1 commit intothunderbird:mainfrom
deckertron9000 wants to merge 1 commit intothunderbird:mainfrom
Conversation
When a display name contains an email address (e.g. Firefox Relay's "original@sender.com [via Relay]" format), spoof prevention was suppressing the display name entirely and showing only the relay address. This aligns with how Thunderbird Desktop handles it by expanding to show both the display name and the actual address in "personal <address>" format. Fixes thunderbird#7367
Contributor
|
Missing report label. Set exactly one of: |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a display name contains an email address (e.g. Firefox Relay's "original@sender.com [via Relay]" format), spoof prevention was suppressing the display name entirely and showing only the relay address. This aligns with how Thunderbird Desktop handles it by expanding to show both the display name and the actual address in
"personal <address>"format.Fixes #7367
I don't expect this to be the final solution here. I mainly wanted to get pen to paper and start a conversation. Things that will likely come up in discussion include this change's utilization of screen real estate and the changing of existing unit tests. I also wonder if this would be better received as a setting to toggle? Could I refactor the formatting logic to eliminate duplication? Let me know your thoughts, happy to iterate.
AI Disclosure: I utilized AI to navigate to relevant portions of code when researching this issue.