Add Thunderbird website hyperlink on contribution screen #8599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcRDZ
force-pushed
the
fix-8430_support-thunderbird-link
branch
3 times, most recently
from
f514fa2 to
9629677
Compare
wmontwe
requested changes
Nov 26, 2024
Member
There was a problem hiding this comment.
Thanks, the direction is great. I just found a better way to support in-text links.
Typicaly, we just change the source translations, but as this introduces a placeholder and Weblate doesn't handle that well. I think editing them here is the safer approach. Before merging this patch, we should pull the latest translations from Weblate and update this patch to ensure all changes are included.
Depends on #8608 <- merged
...ay/src/main/kotlin/app/k9mail/feature/funding/googleplay/ui/contribution/ContributionList.kt
Outdated
Show resolved
Hide resolved
wmontwe
reviewed
Nov 26, 2024
marcRDZ
force-pushed
the
fix-8430_support-thunderbird-link
branch
2 times, most recently
from
0cb881f to
16010d7
Compare
marcRDZ
force-pushed
the
fix-8430_support-thunderbird-link
branch
from
16010d7 to
fe26882
Compare
wmontwe
reviewed
Nov 29, 2024
...ay/src/main/kotlin/app/k9mail/feature/funding/googleplay/ui/contribution/ContributionList.kt
Outdated
Show resolved
Hide resolved
marcRDZ
force-pushed
the
fix-8430_support-thunderbird-link
branch
from
fe26882 to
2c15f2e
Compare
marcRDZ
force-pushed
the
fix-8430_support-thunderbird-link
branch
from
2c15f2e to
84b87f8
Compare
wmontwe
approved these changes
Dec 2, 2024
Member
wmontwe
left a comment
wmontwe
left a comment
There was a problem hiding this comment.
Thank you, just updated two missing translations.
Contributor
Author
|
Don't mention it! I think I lost them merging translations on main rebase. Thanks for the quick fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8430
I've followed this commit c777ad5 as a guide.
I still doubt if I should hoist the click event and handle with a side effect as I've seen for other cases or it's ok on this way.
