Skip to content

Migrate K9.isHideUserAgent to PreferenceDataStore #9423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asoucar merged 2 commits into from
Jul 9, 2025
Merged

Migrate K9.isHideUserAgent to PreferenceDataStore #9423

asoucar merged 2 commits into from
Jul 9, 2025

Conversation

@shamim-emon
Copy link
Collaborator

@shamim-emon shamim-emon commented Jul 4, 2025 •
edited
Loading

Implementation Highlights:

  • Migrated isHideUserAgent from K9 to PrivacySettings.
  • Delegated isHideUserAgent value updates to PrivacySettingsManager.
  • Replaced static reference of isHideUserAgent with access via generalSettings.privacySettings.isHideUserAgent.
  • Updated tests to reflect the migration of isHideUserAgent.

@shamim-emon shamim-emon requested a review from a team as a code owner July 4, 2025 02:14
@shamim-emon shamim-emon requested a review from asoucar July 4, 2025 02:14
@shamim-emon shamim-emon force-pushed the fix-issue-9422 branch 2 times, most recently from bf7f71f to 3b46797 Compare July 4, 2025 03:12
@shamim-emon shamim-emon changed the title Refactor: Replace All Direct Calls To K9.isHideUserAgent With PreferenceDataStore Migrate K9.isHideUserAgent to PreferenceDataStore Jul 4, 2025
@shamim-emon shamim-emon marked this pull request as draft July 8, 2025 12:45
@shamim-emon shamim-emon force-pushed the fix-issue-9422 branch 2 times, most recently from 80d3a1a to 86d00d4 Compare July 8, 2025 20:51
@shamim-emon shamim-emon marked this pull request as ready for review July 8, 2025 21:44
@asoucar asoucar merged commit 532565f into thunderbird:main Jul 9, 2025
3 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 13 milestone Jul 9, 2025
@shamim-emon shamim-emon deleted the fix-issue-9422 branch July 10, 2025 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asoucar asoucar asoucar approved these changes

Assignees

@asoucar asoucar

Labels

None yet

Projects

None yet

Milestone

Thunderbird 12

Development

Successfully merging this pull request may close these issues.

Migrate K9.isHideUserAgent to PreferenceDataStore

3 participants

@shamim-emon @asoucar @coreycb