Skip to content

Conversation

@rafaeltonholo
Copy link
Member

Depends on #9492.

Changeset split from #9415.
Part of #9245.

  • Add system notification style
  • Add in-app notification style

Difference between #9245 and this PR:

  • Removed notificationStyle DSL in favour of separate DSL for SystemNotificationStyle and InAppNotificationStyle

@rafaeltonholo rafaeltonholo requested a review from wmontwe July 23, 2025 17:39
@rafaeltonholo rafaeltonholo requested a review from a team as a code owner July 23, 2025 17:39
@rafaeltonholo rafaeltonholo marked this pull request as draft July 23, 2025 17:40
@rafaeltonholo rafaeltonholo force-pushed the feat/9245/add-notification-styles branch 2 times, most recently from 84a67ba to d0a228b Compare July 24, 2025 15:18
@rafaeltonholo rafaeltonholo marked this pull request as ready for review July 24, 2025 15:18
@rafaeltonholo rafaeltonholo force-pushed the feat/9245/add-notification-styles branch from d0a228b to 496e271 Compare July 24, 2025 15:46
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the DSL 👍

@rafaeltonholo rafaeltonholo merged commit 3edf3f8 into thunderbird:main Jul 25, 2025
3 checks passed
@rafaeltonholo rafaeltonholo deleted the feat/9245/add-notification-styles branch July 25, 2025 10:57
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 13 milestone Jul 25, 2025
@rafaeltonholo rafaeltonholo linked an issue Jul 29, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In-App Error Notifications - Create NotificationSender

2 participants