Skip to content

feat(notification): trigger system notification using SystemNotificationNotifier #9507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rafaeltonholo merged 4 commits into from
Jul 28, 2025
Merged

feat(notification): trigger system notification using SystemNotificationNotifier #9507

rafaeltonholo merged 4 commits into from
Jul 28, 2025

Conversation

@rafaeltonholo
Copy link
Member

@rafaeltonholo rafaeltonholo commented Jul 25, 2025

Depends on #9500, #9506
Changeset split from #9415.
Part of #9245.

  • Implement the SystemNotificationCommand and SystemNotificationNotifier
  • Add AlarmPermissionMissingNotificationTapActionIntentCreator to handle the notification tap action for AlarmPermissionMissingNotification
  • trigger system notification using SystemNotificationNotifier

Difference between #9245 and this PR:

  • Dropped the SystemNotificationIntentCreator in favour of NotificationActionIntentCreator, removing unnecessary duplication
  • Dropped the NotificationIdFactory in favour of NotificationRegistry

Screen recording:

Screen.Recording.2025-07-25.at.12.24.26.PM.mp4

@rafaeltonholo rafaeltonholo requested a review from wmontwe July 25, 2025 15:25
@rafaeltonholo rafaeltonholo requested a review from a team as a code owner July 25, 2025 15:25
@rafaeltonholo rafaeltonholo force-pushed the feat/9245/add-system-notification-command-implementation branch 2 times, most recently from 805f8f7 to 2f87a77 Compare July 25, 2025 17:06
@rafaeltonholo rafaeltonholo mentioned this pull request Jul 25, 2025
Merged
@rafaeltonholo rafaeltonholo force-pushed the feat/9245/add-system-notification-command-implementation branch from 2f87a77 to 5cc7741 Compare July 28, 2025 10:49
wmontwe
wmontwe approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaeltonholo rafaeltonholo force-pushed the feat/9245/add-system-notification-command-implementation branch from 5cc7741 to c2a3d9b Compare July 28, 2025 13:58
@rafaeltonholo rafaeltonholo merged commit d8d92d5 into thunderbird:main Jul 28, 2025
3 checks passed
@rafaeltonholo rafaeltonholo deleted the feat/9245/add-system-notification-command-implementation branch July 28, 2025 15:10
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 13 milestone Jul 28, 2025
@rafaeltonholo rafaeltonholo mentioned this pull request Jul 28, 2025
Closed
@rafaeltonholo rafaeltonholo linked an issue Jul 29, 2025 that may be closed by this pull request
In-App Error Notifications - Create NotificationSender #9245
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmontwe wmontwe wmontwe approved these changes

Assignees

@wmontwe wmontwe

Labels

None yet

Projects

None yet

Milestone

Thunderbird 13

Development

Successfully merging this pull request may close these issues.

In-App Error Notifications - Create NotificationSender

2 participants

@rafaeltonholo @wmontwe