Skip to content

Conversation

@rafaeltonholo
Copy link
Member

@rafaeltonholo rafaeltonholo commented Jul 25, 2025

Depends on #9500, #9506
Changeset split from #9415.
Resolve #9245.

  • Implement the InAppNotificationCommand and InAppNotificationNotifier
  • Add InAppNotificationEventBus and InAppNotificationReceiver to broadcast the notification over the application without using Android BroadcastReceiver.
  • Add InAppNotificationReceiverCompat to enable Java classes to consume the InAppNotificationReceiver without requiring RxJava or other Flow converters.

Difference between #9245 and this PR:

  • Dropped the usage of BroadcastReceiver in favour of InAppNotificationEventBus
  • "Show" in-app notification within the Debug secret screen via the "Notification status log" section.
Screen.Recording.2025-07-25.at.12.24.26.PM.mov

@rafaeltonholo rafaeltonholo requested a review from a team as a code owner July 25, 2025 20:01
@rafaeltonholo rafaeltonholo requested a review from wmontwe July 25, 2025 20:01
@rafaeltonholo rafaeltonholo force-pushed the feat/9245/add-in-app-notification-command-implementation branch 2 times, most recently from 1ff877f to 9ef3417 Compare July 28, 2025 14:36
@rafaeltonholo rafaeltonholo force-pushed the feat/9245/add-in-app-notification-command-implementation branch from 9ef3417 to 4f57aa0 Compare July 28, 2025 15:23
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

val notification = FakeNotification(
severity = NotificationSeverity.Information,
)
val notifier = spy(FakeInAppNotificationNotifier())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the use of spy, makes the fakes way simples as you don't need to record any invocations within the fake.

@rafaeltonholo rafaeltonholo merged commit 5965cf4 into thunderbird:main Jul 29, 2025
3 checks passed
@rafaeltonholo rafaeltonholo deleted the feat/9245/add-in-app-notification-command-implementation branch July 29, 2025 10:44
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 13 milestone Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In-App Error Notifications - Create NotificationSender

2 participants