Skip to content

Conversation

@rafaeltonholo
Copy link
Member

@rafaeltonholo rafaeltonholo commented Jul 28, 2025

Uplift #9472 to beta.

The changes on #9472 supersede the changes on #9433, correctly fixing the navigate back issue without crashing the app when trying to open a Threaded view.

[Approval Request]
Original Issue/Pull request: #9272
Regression caused by (issue #): #9433
User impact if declined: The user won't be able to open the Threaded view if the setting is enabled
Testing completed (on daily, etc.): Testing completed on Daily build (TfA 13.0a1 22091323) and on main
Risk to taking this patch (and alternatives if risky): N/A

@rafaeltonholo rafaeltonholo requested a review from coreycb July 28, 2025 15:09
@rafaeltonholo rafaeltonholo requested a review from a team as a code owner July 28, 2025 15:09
@rafaeltonholo rafaeltonholo requested review from wmontwe and removed request for a team July 28, 2025 15:09
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected.

@rafaeltonholo rafaeltonholo changed the title Uplift: fix back button not closing app when message list is in inbox after returning from another folder and pressing back Uplift: fix(message-list): app crash when threaded view is enabled Jul 28, 2025
@coreycb coreycb added this to the Thunderbird 12 milestone Jul 28, 2025
@coreycb
Copy link
Collaborator

coreycb commented Jul 28, 2025

Risk to taking this patch (and alternatives if risky): N/A

There is always risk in taking a patch that affects executable code. This does not need to be an in-depth analysis.. a few sentences is enough. The patch should be evaluated for what could go wrong. This helps evaluate the risk of taking the patch vs the risk of not taking the patch.

In the future, please add a thoughtful response for this field. I know it can feel cumbersome to follow the uplift process, however there is not much point in having a process if we don't follow it.

Considering this patch has been tested on daily by the reporter and we have 5 weeks until the release of 12.0, I am going to accept the uplift in this case.

@coreycb coreycb merged commit 552d938 into thunderbird:beta Jul 28, 2025
6 checks passed
@rafaeltonholo rafaeltonholo deleted the uplift/9472/fix-navigating-back-not-working branch September 2, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants