Skip to content

Conversation

@rafaeltonholo
Copy link
Member

@rafaeltonholo rafaeltonholo commented Aug 7, 2025

Related to #9456 and #9509

This PR is meant to fix the following test failure:

ValidateLogger > no class should use Timber logging FAILED
    com.lemonappdev.konsist.core.exception.KoAssertionFailedException: Assert 'no class should use Timber logging' was violated (1 time).
    No class should use timber.log.Timber import, use net.thunderbird.core.logging.Logger instead.
    Invalid files:
    └── File DebugLogConfigurator.kt file:///home/runner/work/thunderbird-android/thunderbird-android/core/logging/impl-legacy/src/androidMain/kotlin/net/thunderbird/core/logging/legacy/DebugLogConfigurator.kt
        at app//com.lemonappdev.konsist.core.verify.KoDeclarationAndProviderAssertCoreKt.getResult(KoDeclarationAndProviderAssertCore.kt:224)
        at app//com.lemonappdev.konsist.core.verify.KoDeclarationAndProviderAssertCoreKt.assert(KoDeclarationAndProviderAssertCore.kt:56)
        at app//com.lemonappdev.konsist.api.verify.KoDeclarationAndProviderAssertKt.assertFalse(KoDeclarationAndProviderAssert.kt:100)
        at app//com.lemonappdev.konsist.api.verify.KoDeclarationAndProviderAssertKt.assertFalse$default(KoDeclarationAndProviderAssert.kt:94)
        at app//net.thunderbird.quality.ValidateLogger.no class should use Timber logging(ValidateLogger.kt:35)

Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmontwe wmontwe merged commit fbcbbff into thunderbird:main Aug 7, 2025
5 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 13 milestone Aug 7, 2025
@rafaeltonholo rafaeltonholo deleted the fix/validator-logger-quality-test branch August 7, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants