refactor: message list fragment #9770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmontwe
changed the title
wmontwe
force-pushed
the
refactor-message-list-fragment
branch
from
7942ac5 to
9e0111f
Compare
Member
Author
|
@rafaeltonholo I fixed some issues by removing the generic class injections which should help koin to inject the right implementation. But still need to fix the archive folder creation. |
wmontwe
force-pushed
the
refactor-message-list-fragment
branch
from
5cd1c54 to
8dee5f7
Compare
Member
Author
|
I updated the dependency injection to remove the star-projections as koin is not capable to inject the right dependency at runtime. Neither is the This required a larger effort and I moved feature specific injections to |
LegacyAccountManager now implements AccountManager<LegacyAccount>
…torageFactory interface
…egacyAccountDtoSpecialFolderUpdaterFactory
wmontwe
force-pushed
the
refactor-message-list-fragment
branch
from
8dee5f7 to
5063c39
Compare
rafaeltonholo
requested changes
Sep 17, 2025
Member
rafaeltonholo
left a comment
rafaeltonholo
left a comment
There was a problem hiding this comment.
Thanks for starting the message list fragment refactor! I already see many improvements after this PR!
There are just a few things that we need to address before merging these changes. Let me know if you have any questions
legacy/core/src/main/java/com/fsck/k9/mailstore/LocalStoreProvider.kt
Outdated
Show resolved
Hide resolved
.../test/kotlin/net/thunderbird/app/common/feature/mail/BaseAccountBackendStorageFactoryTest.kt
Outdated
Show resolved
Hide resolved
...src/test/kotlin/net/thunderbird/app/common/feature/mail/BaseAccountImapBackendFactoryTest.kt
Outdated
Show resolved
Hide resolved
...kotlin/net/thunderbird/app/common/feature/mail/BaseAccountSpecialFolderUpdaterFactoryTest.kt
Outdated
Show resolved
Hide resolved
...n/src/test/kotlin/net/thunderbird/app/common/feature/mail/RemoteFolderCreatorResolverTest.kt
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt
Outdated
Show resolved
Hide resolved
legacy/ui/legacy/src/main/java/com/fsck/k9/ui/messagelist/MessageListFragment.kt
Show resolved
Hide resolved
wmontwe
force-pushed
the
refactor-message-list-fragment
branch
from
5063c39 to
a8caa14
Compare
rafaeltonholo
approved these changes
Sep 17, 2025
Member
rafaeltonholo
left a comment
rafaeltonholo
left a comment
There was a problem hiding this comment.
LGTM, thanks for addressing all the comments!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #9763
Preparation for the new message list item ui #9654
This removes the dependency on the
LegacyAccountDtoand replaces it withLegacyAccount, which is a data class and allows composables to detect changes.The
MessageListFragmentis doing too much in it's current form, but this is a task for another day.It also adds new factories and resolvers for backend storage, IMAP backend, special folder updating, and remote folder creation. The dependency injection setup is updated to include these new components.