-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
ci(dependabot): add workflow to automatically update dependency guard when dependabot creates a PR #9805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(dependabot): add workflow to automatically update dependency guard when dependabot creates a PR #9805
Conversation
wmontwe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I don't think the git push will work because the default permissions for actions on this repo don't allow write. I would hope those settings apply to PR branches as well. I think we should be reducing the "permissions:" of the GITHUB_TOKEN to at least read, and instead use actions/create-github-app-token. |
Since this only pushes to the pull request's branch, I don't think it will require any special permissions. I reviewed the documentation again and realized that I had missed adding the Aside from that adjustment, I believe we should be able to commit and push without any issues. I don't think we need a custom token for this, as it still requires approval as part of the pull request process. |
d87644f to
02deb27
Compare
… when dependabot creates a PR
02deb27 to
c72d3a3
Compare
I agree and the permissions should be reduced to read already based on the repo settings. LGTM |
…bot-dependency-guard-update-workflow ci(dependabot): add workflow to automatically update dependency guard when dependabot creates a PR
…bot-dependency-guard-update-workflow ci(dependabot): add workflow to automatically update dependency guard when dependabot creates a PR
…bot-dependency-guard-update-workflow ci(dependabot): add workflow to automatically update dependency guard when dependabot creates a PR
Whenever
@dependabotupdates an Android version, the app will challenge the new version with the dependency guard, and the CI will fail.This PR creates a workflow that, whenever
@dependabotopens, reopens or updates a PR, this workflow will trigger and update the dependency guard if required.