Skip to content

Decouple DebugLogConfigurator From Timber And Relocate to New Logger Infra #9816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wmontwe merged 3 commits into from
Sep 26, 2025
Merged

Decouple DebugLogConfigurator From Timber And Relocate to New Logger Infra #9816

wmontwe merged 3 commits into from
Sep 26, 2025

Conversation

@shamim-emon
Copy link
Collaborator

@shamim-emon shamim-emon commented Sep 17, 2025 •
edited
Loading

Implementation Highlights:

  • Created a new module :core:logging:config and moved DebugLogConfigurator into it.
  • Eliminate direct dependency on timber.log.Timber in DebugLogConfigurator.
  • Removed DebugLogConfigurator from the Timber logging exclusion list in the ValidateLogger.

@shamim-emon shamim-emon requested a review from a team as a code owner September 17, 2025 17:40
@shamim-emon shamim-emon requested a review from wmontwe September 17, 2025 17:40
@shamim-emon shamim-emon force-pushed the fix-issue-9573 branch 2 times, most recently from f7f92cb to 1843b4c Compare September 17, 2025 17:46
@shamim-emon shamim-emon changed the title Move DebugLogConfigurator into new logger infrastructure Decouple DebugLogConfigurator From Timber And Relocate to New Logger Infra Sep 18, 2025
@shamim-emon shamim-emon force-pushed the fix-issue-9573 branch 2 times, most recently from dcd7c83 to dfe6cde Compare September 20, 2025 08:04
wmontwe
wmontwe requested changes Sep 25, 2025
View reviewed changes
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is now KMP ready and could be moved to commonMain

@shamim-emon shamim-emon requested a review from wmontwe September 25, 2025 16:01
wmontwe
wmontwe approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmontwe wmontwe merged commit 315b898 into thunderbird:main Sep 26, 2025
14 checks passed
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 14 milestone Sep 26, 2025
@shamim-emon shamim-emon deleted the fix-issue-9573 branch September 26, 2025 11:01
@wmontwe wmontwe mentioned this pull request Sep 26, 2025
Merged
@shamim-emon shamim-emon mentioned this pull request Sep 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmontwe wmontwe wmontwe approved these changes

Assignees

@wmontwe wmontwe

Labels

None yet

Projects

None yet

Milestone

Thunderbird 14

Development

Successfully merging this pull request may close these issues.

Move DebugLogConfigurator into new logger infrastructure

2 participants

@shamim-emon @wmontwe