Skip to content

Conversation

@wmontwe
Copy link
Member

@wmontwe wmontwe commented Sep 18, 2025

Resolves #9654

The design is not covering the MessageListAppearance options. We need another round of discussion how to handle these.

@wmontwe wmontwe requested a review from a team as a code owner September 18, 2025 13:53
@wmontwe wmontwe force-pushed the feat-message-list-change-item-layout branch from 87bbaeb to 3f8864e Compare September 18, 2025 13:56
@wmontwe wmontwe changed the title Feat message list change item layout feat(message-list): change item layout Sep 18, 2025
Copy link
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes! There are a few things I believe we need to address before merging this.

@rafaeltonholo
Copy link
Member

I also want to mention a few things that are not related to these changes, but we need to address/discuss more about them:

  1. Currently, we don't have an indication of which account the message belongs to when in the Unified inbox (Require design)
  2. In the previous version of the Message List, whenever we have a message that is encrypted, the preview text is replaced with *Encrypted*. The present implementation will leave it empty. We need to discuss if that is what we expect.
  3. There are a few layout changes that I would like to discuss more about.

@wmontwe
Copy link
Member Author

wmontwe commented Sep 19, 2025

@rafaeltonholo the implementation is not complete as I mentioned above. This just adds the available ui components and a view holder with partial integration. It doesn't make sense to continue at the moment as we need to fix the design first before further adding code. I planed to create follow up tickets, but had no time yesterday.

These changes are guarded by a feature flag and I'll turn it of until we have a design update.

@wmontwe
Copy link
Member Author

wmontwe commented Sep 19, 2025

I also want to mention a few things that are not related to these changes, but we need to address/discuss more about them:

1. Currently, we don't have an indication of which account the message belongs to when in the Unified inbox (Require design)

2. In the previous version of the Message List, whenever we have a message that is encrypted, the preview text is replaced with `*Encrypted*`. The present implementation will leave it empty. We need to discuss if that is what we expect.

3. There are a few layout changes that I would like to discuss more about.

I know, just no time to add tickets for. I did a hard stop yesterday and wanted to discuss the design first before adding more code. Especially as the list items already have a very large api surface, that needs to be addressed too. I think this should be covered in another issue.

And the option to have alternating colors for the avatar.

@wmontwe wmontwe force-pushed the feat-message-list-change-item-layout branch 2 times, most recently from a917468 to 7dc61a8 Compare September 19, 2025 10:27
@wmontwe wmontwe force-pushed the feat-message-list-change-item-layout branch from 7dc61a8 to 8c172c3 Compare September 19, 2025 10:33
@rafaeltonholo
Copy link
Member

@rafaeltonholo the implementation is not complete as I mentioned above. This just adds the available ui components and a view holder with partial integration. It doesn't make sense to continue at the moment as we need to fix the design first before further adding code. I planed to create follow up tickets, but had no time yesterday.

These changes are guarded by a feature flag and I'll turn it of until we have a design update.

Sounds good to me! Thanks for explaining that

Copy link
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmontwe wmontwe merged commit 1877d84 into thunderbird:main Sep 19, 2025
14 checks passed
@wmontwe wmontwe deleted the feat-message-list-change-item-layout branch September 19, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace MessageList items with new UI components

2 participants