-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore(deps): bump Gradle from 8.14.3 to 9.1.0 #9979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There is an issue with Gradle 9.1 and AGP adding resources to test classes dir: AGP causing deprecation warnings in Gradle for JVM test tasks (411739086) Which fails the tests if module has not tests. |
The issue is marked as fixed, but it seems like only on AGP 9. Until we can upgrade to the latest AGP, we may need to implement the workaround listed in the issue tracker: Index: build-plugin/src/main/kotlin/thunderbird.library.android.gradle.kts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/build-plugin/src/main/kotlin/thunderbird.library.android.gradle.kts b/build-plugin/src/main/kotlin/thunderbird.library.android.gradle.kts
--- a/build-plugin/src/main/kotlin/thunderbird.library.android.gradle.kts (revision c81beb1c5592d89471599f183160f159a711497b)
+++ b/build-plugin/src/main/kotlin/thunderbird.library.android.gradle.kts (date 1761045595263)
@@ -18,7 +18,7 @@
testOptions {
unitTests {
- isIncludeAndroidResources = true
+ isIncludeAndroidResources = project.layout.projectDirectory.dir("src/test").asFile.exists()
}
}
}
Index: build-plugin/src/main/kotlin/thunderbird.library.android.compose.gradle.kts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/build-plugin/src/main/kotlin/thunderbird.library.android.compose.gradle.kts b/build-plugin/src/main/kotlin/thunderbird.library.android.compose.gradle.kts
--- a/build-plugin/src/main/kotlin/thunderbird.library.android.compose.gradle.kts (revision c81beb1c5592d89471599f183160f159a711497b)
+++ b/build-plugin/src/main/kotlin/thunderbird.library.android.compose.gradle.kts (date 1761045595258)
@@ -8,6 +8,11 @@
android {
configureSharedComposeConfig(libs)
+ testOptions {
+ unitTests {
+ isIncludeAndroidResources = project.layout.projectDirectory.dir("src/test").asFile.exists()
+ }
+ }
}
androidComponents {
Index: build-plugin/src/main/kotlin/AndroidExtension.kt
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/build-plugin/src/main/kotlin/AndroidExtension.kt b/build-plugin/src/main/kotlin/AndroidExtension.kt
--- a/build-plugin/src/main/kotlin/AndroidExtension.kt (revision c81beb1c5592d89471599f183160f159a711497b)
+++ b/build-plugin/src/main/kotlin/AndroidExtension.kt (date 1761045204466)
@@ -30,7 +30,7 @@
testOptions {
unitTests {
- isIncludeAndroidResources = true
+ isIncludeAndroidResources = project.layout.projectDirectory.dir("src/test").asFile.exists()
}
} |
|
I changed the setup to only enable |
rafaeltonholo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #9582