Skip to content

docs: add database migration checklist#9996

Merged
wmontwe merged 3 commits intothunderbird:mainfrom
wmontwe:docs-add-database-migration-checklist
Nov 4, 2025
Merged

docs: add database migration checklist#9996
wmontwe merged 3 commits intothunderbird:mainfrom
wmontwe:docs-add-database-migration-checklist

Conversation

@wmontwe
Copy link
Member

@wmontwe wmontwe commented Oct 23, 2025

Resolves #9995

@wmontwe wmontwe force-pushed the docs-add-database-migration-checklist branch from ded2ca4 to d4ce40a Compare October 29, 2025 17:39
@wmontwe wmontwe removed request for a team and kewisch October 29, 2025 17:40
@wmontwe wmontwe requested a review from rafaeltonholo October 30, 2025 10:34
Comment on lines 152 to 153
- Last shipped beta migration: `MigrationTo6.kt`
- Last migration on beta: `MigrationTo7.kt`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like this is wrong... Shouldn't it be:

Suggested change
- Last shipped beta migration: `MigrationTo6.kt`
- Last migration on beta: `MigrationTo7.kt`
- Last shipped release migration: `MigrationTo4.kt`
- Last migration on beta: `MigrationTo6.kt`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the documentation.

- Take the unreleased `MigrationTo7.kt` and reintroduce it as `MigrationTo12.kt`, adjusted against the new base schema (post‑`11`).
- Bump `DB_VERSION` to `12`, register `MigrationTo12.kt`.
- Update `dbCreateDatabaseFromScratch` to reflect post-`12` schema.
- Remove old `MigrationTo7.kt` from `beta`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be:

Remove old MigrationTo7.kt from main.

in this situation?

Considering that the current db on beta is 7, and the last Migration applied was Migration6.kt, the Migration7.kt does not exist in the beta branch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this step is not needed. I updated the documentation.

@wmontwe wmontwe force-pushed the docs-add-database-migration-checklist branch from d4ce40a to 3f732be Compare November 4, 2025 16:33
@wmontwe wmontwe requested a review from rafaeltonholo November 4, 2025 16:37
Copy link
Member

@rafaeltonholo rafaeltonholo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmontwe wmontwe merged commit f929329 into thunderbird:main Nov 4, 2025
4 checks passed
@wmontwe wmontwe deleted the docs-add-database-migration-checklist branch November 4, 2025 19:04
@thunderbird-botmobile thunderbird-botmobile bot added this to the Thunderbird 15 milestone Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add checklist for database migrations

3 participants