Correct typo in 24_typical_flash_part_layout.md#26
Correct typo in 24_typical_flash_part_layout.md#26grahammc-bit wants to merge 2 commits intotianocore-docs:release/1.28from
Conversation
makubacki
left a comment
makubacki
left a comment
There was a problem hiding this comment.
Content looks good, but need the commit message updated.
| @@ -42,7 +42,7 @@ the tools for creating a compressed image and a library for decompressing the | |||
| image must be provided. These non-standard compression, encryption, signing or | |||
| verification mechanisms are applied to a GUIED encapsulation section. Each | |||
There was a problem hiding this comment.
Could you fix this at the same time please?
Similar to below, I think it should be "GUIDED".
There was a problem hiding this comment.
I'll make the change but will need confirmation regarding validity. Thank you for the suggestion.
|
Can you please add the |
|
I see this is targeting a release branch. This change look like it should go to the master branch first and then a different PR to apply to 1.28 branch if that is required. A change to master branch would be included in the next official release. |
Update facility -> facilitate. I believe this was the intended verbiage from the original author.
Update 24_typical_flash_part_layout.md Updated the following lines in 24_typical_flash_part_layout.md: Line 43: GUIED -> GUIDED Line 45: facility -> facilitate Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Matthew Graham <matthew.graham@amd.com>
mdkinney
requested review from
ardbiesheuvel,
leiflindholm and
mdkinney
as code owners
4 participants
Update 24_typical_flash_part_layout.md
Updated the following lines in 24_typical_flash_part_layout.md:
Line 43: GUIED -> GUIDED
Line 45: facility -> facilitate
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Matthew Graham matthew.graham@amd.com