Skip to content

Add GHSA PR Checks#10950

Closed
makubacki wants to merge 1 commit intotianocore:masterfrom
makubacki:add_gh_workflow_linux_build
Closed

Add GHSA PR Checks#10950
makubacki wants to merge 1 commit intotianocore:masterfrom
makubacki:add_gh_workflow_linux_build

Conversation

@makubacki
Copy link
Copy Markdown
Member

@makubacki makubacki commented Apr 11, 2025 •
edited
Loading

Description

Performs simple CI checks against a common set of pacakges and
targets for PRs in private tianocore GitHub Security Advisory
(GHSA) forks. This is meant to provide relatively simple sanity
checks there before the contributions are run against public
CI infrastructure.

  • Breaking change?
  • Impacts security?
  • Includes tests?

How This Was Tested

Integration Instructions

  • N/A

@makubacki makubacki self-assigned this Apr 11, 2025
@makubacki makubacki force-pushed the add_gh_workflow_linux_build branch 4 times, most recently from 5f609fd to 492742d Compare April 11, 2025 20:52
@makubacki
.github/workflows: Add GHSA PR Gate workflow
438a65c 
Performs simple CI checks against a common set of pacakges and
targets for PRs in private tianocore GitHub Security Advisory
(GHSA) forks. This is meant to provide relatively simple sanity
checks there before the contributions are run against public
CI infrastructure.

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
@makubacki makubacki force-pushed the add_gh_workflow_linux_build branch from 492742d to 438a65c Compare April 11, 2025 21:05
@makubacki makubacki marked this pull request as ready for review April 11, 2025 21:07
@tianocore-assign-reviewers
Copy link
Copy Markdown

tianocore-assign-reviewers bot commented Apr 11, 2025

⚠ WARNING: Cannot add some reviewers: A user specified as a reviewer for this PR is not a collaborator of the repository. Please add them as a collaborator to the repository so they can be requested in the future.

Non-collaborators requested:

Attn Admins:

Admin Instructions:

  • Add the non-collaborators as collaborators to the appropriate team(s) listed in teams
  • If they are no longer needed as reviewers, remove them from Maintainers.txt

Javagedes
Javagedes reviewed Apr 11, 2025
View reviewed changes
@makubacki
Copy link
Copy Markdown
Member Author

makubacki commented Apr 11, 2025

I should have read github/roadmap#627 before starting this. The workflow does work but GitHub currently does not support running actions from GHSA private forks. I'm going to leave this PR up and rework it for normal CI to help provide a path to move our infrastructure (even if only partially) more into GitHub.

Javagedes
Javagedes reviewed Apr 11, 2025
View reviewed changes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 10, 2025

This PR has been automatically marked as stale because it has not had activity in 60 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Due to lack of updates, this item is pending deletion. label Jun 10, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 17, 2025

This pull request has been automatically been closed because it did not have any activity in 60 days and no follow up within 7 days after being marked stale. Thank you for your contributions.

@github-actions github-actions bot closed this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Javagedes Javagedes Javagedes left review comments

@mdkinney mdkinney Awaiting requested review from mdkinney

@spbrogan spbrogan Awaiting requested review from spbrogan

Assignees

@makubacki makubacki

Labels

stale Due to lack of updates, this item is pending deletion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@makubacki @Javagedes