RedfishPkg/ConfigHandler: Remove [Depex] section from INF file#12395
RedfishPkg/ConfigHandler: Remove [Depex] section from INF file#12395changab wants to merge 2 commits intotianocore:masterfrom
Conversation
Pull Request Formatting Issues
Address these issues and the validation will automatically re-run when you update your pull request. |
tianocore-assign-reviewers
bot
requested review from
igorkulchytskyy and
nicklela
changab
force-pushed
the
ConfigHandle
branch
2 times, most recently
from
cae6fb3 to
12ccbd1
Compare
|
Please link the issue with the PR probably. Suggestion: Use This auto-closes the issue when PR is merged. |
| // | ||
| // Check if the Redfish credential protocol is installed or not. | ||
| // | ||
| Status = RedfishConfigCommonInit (); |
There was a problem hiding this comment.
Hmm... I am not a fan of calling init function in supported function. The end-of-dxe event and exit-boot-service event are created multiple times.
Could we just test and see if gEdkIIRedfishCredentialProtocolGuid is installed or not?
There was a problem hiding this comment.
Yes, we can test this procotol in the Support function and locate it in the Start().
Also, thanks for catching the multiple event registration issue.
UEFI driver shouldn't have the [Depex] section in INF file. Remove Redfish Credential Protocol in dependency section and locate it when the UEFI driver is connected to execute. Signed-off-by: Abner Chang <abner.chang@amd.com>
nicklela
left a comment
nicklela
left a comment
There was a problem hiding this comment.
Looks good to me but I have one minor comment.
| **/ | ||
|
|
||
| #pragma once | ||
| #ifndef EFI_REDFISH_CONFIG_HANDLER_COMMON_H_ |
There was a problem hiding this comment.
Edk2 has replaced include guards with pragma once, please refer #12149.
4 participants
UEFI driver shouldn't have the [Depex] section in INF file. Remove Redfish Credential Protocol in the dependency section and locate it when the UEFI driver is connected to execute.
Description
fixes: #12394
UEFI driver shouldn't have a [Depex] section.
How This Was Tested
Verified the functionality on AMD platform.
Integration Instructions
N/A