MdeModulePkg/CapsuleOnDisk: Skip network boot options when searching for ESP#12433
Open
anandhkrishnau wants to merge 1 commit intotianocore:masterfrom
Open
MdeModulePkg/CapsuleOnDisk: Skip network boot options when searching for ESP#12433anandhkrishnau wants to merge 1 commit intotianocore:masterfrom
anandhkrishnau wants to merge 1 commit intotianocore:masterfrom
Conversation
When CapsuleApp or DxeCapsuleLibFmp searches for an EFI System Partition (ESP) to write capsule-on-disk data, it iterates through all active boot options in BootOrder. If network boot options (HTTP Boot, PXE) appear before disk-based options, EfiBootManagerConnectDevicePath() is called on each network device path, triggering actual HTTP/PXE boot attempts that are slow and always fail since network devices cannot contain an ESP. Add IsNetworkBootDevicePath() to detect device paths containing MSG_MAC_ADDR_DP, MSG_IPv4_DP, MSG_IPv6_DP, or MSG_URI_DP nodes and skip them during the boot option iteration in both: - CapsuleApp (GetUpdateFileSystem) - DxeCapsuleLibFmp (GetEfiSysPartitionFromActiveBootOption) This avoids unnecessary network connection attempts and significantly reduces capsule-on-disk provisioning time on systems with network boot options enabled. Signed-off-by: default avatarAnandh krishnau U <anandhkrishanu@ami.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When CapsuleApp or DxeCapsuleLibFmp searches for an EFI System Partition (ESP) to write capsule-on-disk data, it iterates through all active boot options in BootOrder. If network boot options (HTTP Boot, PXE) appear before disk-based options, EfiBootManagerConnectDevicePath() is called on each network device path, triggering actual HTTP/PXE boot attempts that are slow and always fail since network devices cannot contain an ESP.
Add IsNetworkBootDevicePath() to detect device paths containing MSG_MAC_ADDR_DP, MSG_IPv4_DP, MSG_IPv6_DP, or MSG_URI_DP nodes and skip them during the boot option iteration in both:
This avoids unnecessary network connection attempts and significantly reduces capsule-on-disk provisioning time on systems with network boot options enabled.
How This Was Tested
Tested with HTTP and PXE boot options enabled.
Verified CapsuleApp no longer triggers network boot attempts during
capsule-on-disk provisioning.
Integration Instructions
N/A