Open
Conversation
Signed-off-by: Jeremy Bobbin <jer@jer.cx>
Member
|
we have a plugin that checks for this automatically across files in packages. Could that be used somehow to not only catch these issues but prevent regressions? At first glance i think there are two issues.
Anyway, look forward to seeing if there is a way to avoid these problems coming back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch fixes the invalid UTF-8 sequences which caused me some problems with CI(in the attempt to remove the carriage returns).
Some of the CI scripts(like the following) read the diff as UTF-8:
.pytool\Plugin\EccCheck\EccCheck.py.pytool\Plugin\LicenseCheck\LicenseCheck.pyThis means that if invalid UTF-8 was removed in a patch, it will raise an exception.
I do not anticipate this passing CI, however, if merged, it should prevent future CI problems.
How This Was Tested
Tested with OVMF in QEMU. I ran the affected make files to assert that there were no new parsing errors. I built
antlr&dlgwith no issues.Integration Instructions
N/A