feat: Update support for Python versions > 3.10 #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible-runner came out 1 year after the machine-stats and the library matched how we wanted to use ansible, as a way to interact with ansible through a custom cli. So, I've added ansible-runner to be our primary interface to ansible and plan on cleaning up the code in __init__ to more closely match our new usage.
SamDesmondKing
approved these changes
Nov 6, 2025
Contributor
SamDesmondKing
left a comment
SamDesmondKing
left a comment
There was a problem hiding this comment.
Awesome work, you're a magician. Like I said I'll take it for a spin later today and report back if any issues
| author="Tidal", | ||
| author_email="[email protected]", | ||
| description="A simple and effective way to gather machine statistics (RAM, Storage, CPU, etc.) from virtual environment", | ||
| description="This program is now deprecated.\n\nA simple and effective way to gather machine statistics (RAM, Storage, CPU, etc.) from virtual environment", |
unix/Pipfile
Outdated
|
|
||
| [packages] | ||
| ansible = "<2.10" | ||
| ansible = "<6" |
Contributor
There was a problem hiding this comment.
phew that's a lot of major versions
unix/Pipfile
Outdated
|
|
||
| [packages] | ||
| ansible = "<6" | ||
| ansible-core = "==2.12" |
Contributor
There was a problem hiding this comment.
ah yep I remember you talking about this
| nargs="*", | ||
| ) | ||
|
|
||
| parser.add_argument( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous versions of machine stats we used an outdated way of wrapping the ansible CLI. This refactor allows us to use Ansible's approved way of programmatically running Ansible, through
ansible-runner.Now, we can more easily maintain the same support for Ansible versions as
ansible-runnerwhich, as of this writing, is anything 3.10 and above.Additionally, for convenience I've also added a
--versionflag command for ease of future debugging efforts.