Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/check-dist.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ jobs:
steps:
- name: Checkout
id: checkout
uses: actions/checkout@v4

uses: actions/checkout@v6
with:
persist-credentials: false

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any purpose of this?
Or this was required when updating the package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a lint action and I think it's a general best practice unless you need the credentials later on.
See:
https://docs.zizmor.sh/audits/#artipacked

- name: Setup Node.js
id: setup-node
uses: actions/setup-node@v6
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@ jobs:
steps:
- name: Checkout
id: checkout
uses: actions/checkout@v4

uses: actions/checkout@v6
with:
persist-credentials: false
- name: Setup Node.js
id: setup-node
uses: actions/setup-node@v6
Expand Down Expand Up @@ -51,8 +52,9 @@ jobs:
steps:
- name: Checkout
id: checkout
uses: actions/checkout@v4

uses: actions/checkout@v6
with:
persist-credentials: false
- name: Test Local Action
id: test-action
uses: ./
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,9 @@ jobs:
steps:
- name: Checkout
id: checkout
uses: actions/checkout@v4
uses: actions/checkout@v6
with:
persist-credentials: false
fetch-depth: 0

- name: Setup Node.js
Expand All @@ -38,7 +39,7 @@ jobs:

- name: Lint Codebase
id: super-linter
uses: super-linter/super-linter/slim@v7
uses: super-linter/super-linter/slim@v8
env:
DEFAULT_BRANCH: main
FILTER_REGEX_EXCLUDE: dist/**/*
Expand All @@ -47,7 +48,10 @@ jobs:
VALIDATE_ALL_CODEBASE: true
VALIDATE_JAVASCRIPT_ES: false
VALIDATE_JAVASCRIPT_STANDARD: false
VALIDATE_BIOME_FORMAT: false
VALIDATE_BIOME_LINT: false
VALIDATE_JSCPD: false
VALIDATE_TYPESCRIPT_ES: false
VALIDATE_JSON: false
VALIDATE_GITHUB_ACTIONS_ZIZMOR: false
VALIDATE_TYPESCRIPT_STANDARD: false
Loading