-
Notifications
You must be signed in to change notification settings - Fork 3
Add migration command #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds migration command functionality to the TiDB Cloud CLI, enabling users to manage database migrations for TiDB Cloud Serverless clusters. The PR includes generated OpenAPI client code, API integration, and user-facing CLI commands.
Key Changes
- Generated OpenAPI client for the migration API (v7.12.0)
- Integration of migration client into the existing API infrastructure
- New CLI commands for managing migrations (create, list, describe, delete, pause, resume, template)
- Migration task selection UI in the interactive logic layer
Reviewed changes
Copilot reviewed 59 out of 59 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/openapi-generator/openapitools.json | Adds custom Maven repository URL for OpenAPI generator JAR download |
| pkg/tidbcloud/v1beta1/serverless/migration/* | Complete OpenAPI-generated Go client for migration API endpoints and models |
| internal/service/cloud/api_client.go | Integrates migration API client with existing API infrastructure |
| internal/service/cloud/logic.go | Adds migration task selection logic for interactive CLI |
| internal/flag/flag.go | Defines new flag constants for migration commands |
| internal/cli/serverless/migration/migration.go | Root command structure for migration subcommands |
| internal/cli/serverless/migration/template.go | Template generation command for migration configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 60 out of 61 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 60 out of 61 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This pull request introduces a new "migration" command group to the Serverless CLI, enabling users to manage migration tasks for TiDB Cloud Serverless clusters. The changes include generating a new client for the migration Open API, and adding comprehensive command implementations for creating, describing, and deleting migration tasks。