add a site merge endpoint for clinics #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
toddkazakov
reviewed
Sep 3, 2025
reference/clinic.v1.yaml
Outdated
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/site.v1' |
Contributor
There was a problem hiding this comment.
The payload schema isn't correct. The validator will expect a site name to present in the payload (because it's required), but only the id is required and used by the underlying implementation.
Contributor
Author
There was a problem hiding this comment.
The payload schema isn't correct. The validator will expect a site name to present in the payload (because it's required), but only the id is required and used by the underlying implementation.
Fixed, thank you.
ewollesen
force-pushed
the
eric-sites-merge
branch
from
a8aeb19 to
41c65e6
Compare
toddkazakov
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACK-3978