Skip to content

Conversation

@hbugdoll
Copy link
Contributor

According to tidev/titanium-sdk#14341 here a smaller load 😄

Description

Fixes in logs and comments:

  • fixed wording: ABI, Android, API, AVD, CI, CLI, iOS, Java, JDK, JSON, SDK, URI, URL, Windows (the OS), XML
  • fixed i.e.e.g. in sense of an example
  • fixed typos

@cb1kenobi
Copy link
Contributor

Looks good, but the tests are failing:

test at test/util/tiapp.test.js:59:2
✖ should error loading if file is malformed (2.427875ms)
  AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
  + actual - expected
  
    Comparison {
  +   message: 'unclosed xml tag(s): ti:app',
  -   message: 'unclosed XML tag(s): ti:app',
      name: 'ParseError'
    }

@hbugdoll
Copy link
Contributor Author

Ahh, the malformed-xml test compares with the error message from xmldom (https://github.com/xmldom/xmldom/blob/39fc73ebf60d35f76c9ccff0ea92ed02473312e3/lib/sax.js#L123).
I reverted it.

@cb1kenobi cb1kenobi merged commit 272a99e into tidev:main Nov 17, 2025
20 of 21 checks passed
@hbugdoll hbugdoll changed the title chore: fixed typos and wording chore: fixed further typos and wording Nov 17, 2025
@hbugdoll hbugdoll deleted the typos-fix branch November 17, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants