feat(android): add letterSpacing to Label#13984
Merged
hansemannn merged 3 commits intomasterfrom Apr 28, 2025
Merged
Conversation
m1ga
commented
Apr 6, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the letterSpacing property on Android Labels, mirroring the implementation of lineSpacing.
- Updates the API documentation to include letterSpacing.
- Adds a constant for letterSpacing in TiC.java.
- Implements letterSpacing handling in TiUILabel both during initial property processing and on property changes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apidoc/Titanium/UI/Label.yml | Documents the new letterSpacing property |
| android/titanium/src/java/org/appcelerator/titanium/TiC.java | Introduces the PROPERTY_LETTER_SPACING constant |
| android/modules/ui/src/java/ti/modules/titanium/ui/widget/TiUILabel.java | Adds letterSpacing logic in property processing and change handling |
hansemannn
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS can do letterspacing with a attributedString already. Android doesn't have this property. As it just a text property I've added it the same way as
lineSpacingso it is a native Label property.